Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: runtime/bin/socket_macos.cc

Issue 2211523002: Make Mac-port non-blocking. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add 'on Mac' to Changelog. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_macos.cc
diff --git a/runtime/bin/socket_macos.cc b/runtime/bin/socket_macos.cc
index 2e336a2003709fd5377c29f150d1f5b1a6aa7174..e54cc591fe72db61394e30d7708a9028ff019191 100644
--- a/runtime/bin/socket_macos.cc
+++ b/runtime/bin/socket_macos.cc
@@ -58,6 +58,7 @@ static intptr_t Create(const RawAddr& addr) {
return -1;
}
FDUtils::SetCloseOnExec(fd);
+ FDUtils::SetNonBlocking(fd);
return fd;
}
@@ -79,8 +80,6 @@ intptr_t Socket::CreateConnect(const RawAddr& addr) {
return fd;
}
- FDUtils::SetNonBlocking(fd);
-
return Connect(fd, addr);
}
« no previous file with comments | « CHANGELOG.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698