content/browser/download/download_manager_impl_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/suggestions/suggestions_service_unittest.cc ('K') | « content/browser/appcache/chrome_appcache_service_unittest.cc ('k') | content/browser/frame_host/render_widget_host_view_guest_unittest.cc » ('j') | content/browser/site_instance_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_manager_impl_unittest.cc

diff --git a/content/browser/download/download_manager_impl_unittest.cc b/content/browser/download/download_manager_impl_unittest.cc

index 52933cae98f519541ead80fdd16eaca27e349a28..f0eaa820a64726a4f9536a985d7a952fed2ad744 100644

--- a/content/browser/download/download_manager_impl_unittest.cc

+++ b/content/browser/download/download_manager_impl_unittest.cc

@@ -18,6 +18,7 @@

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/stl_util.h"

#include "base/strings/string16.h"

#include "base/strings/string_util.h"

@@ -541,10 +542,9 @@ class DownloadManagerTest : public testing::Test {

download_manager_->Shutdown();

download_manager_.reset();

- message_loop_.RunUntilIdle();

- ASSERT_EQ(NULL, mock_download_item_factory_.get());

- ASSERT_EQ(NULL, mock_download_file_factory_.get());

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

+ ASSERT_EQ(nullptr, mock_download_item_factory_.get());

fdoray 2016/08/04 18:48:21 I removed the duplicated line... I'm not convinced

gab 2016/08/05 01:09:57 Yea, second RunUntilIdle() should be irrelevant, l

fdoray 2016/08/05 16:10:35 Done.

+ base::RunLoop().RunUntilIdle();

mock_download_manager_delegate_.reset();

mock_browser_context_.reset();

download_urls_.clear();