ui/app_list/views/apps_grid_view_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/apps_grid_view_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/tools/testserver/run_testserver.cc ('K') | « ui/app_list/pagination_model_unittest.cc ('k') | ui/aura/demo/demo_main.cc » ('j') | ui/events/platform/platform_event_source_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/app_list/views/apps_grid_view_unittest.cc

diff --git a/ui/app_list/views/apps_grid_view_unittest.cc b/ui/app_list/views/apps_grid_view_unittest.cc

index e0b730cd2bbfd484e9ec34b87dc6f197b06cdb4d..e6eadf3e6e42c9a77e949b3b7055a26626571654 100644

--- a/ui/app_list/views/apps_grid_view_unittest.cc

+++ b/ui/app_list/views/apps_grid_view_unittest.cc

@@ -13,6 +13,7 @@

#include "base/compiler_specific.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

@@ -53,7 +54,7 @@ class PageFlipWaiter : public PaginationModelObserver {

DCHECK(!wait_);

wait_ = true;

- ui_loop_->Run();

+ base::RunLoop().Run();

sadrul 2016/08/08 20:42:42 I think this should remain ui_loop_->Run(), or ui_

fdoray 2016/08/23 15:30:27 Done.

wait_ = false;

}