net/tools/testserver/run_testserver.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/testserver/run_testserver.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/tools/net_watcher/net_watcher.cc ('K') | « net/tools/net_watcher/net_watcher.cc ('k') | ppapi/nacl_irt/irt_pnacl_translator_compile.cc » ('j') | ui/app_list/views/apps_grid_view_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/tools/testserver/run_testserver.cc

diff --git a/net/tools/testserver/run_testserver.cc b/net/tools/testserver/run_testserver.cc

index 6da829d9f315968d25e7bf3e87557887fe035517..8e30710a47e24cc6fd4ae95eb8c5bf54263bce4b 100644

--- a/net/tools/testserver/run_testserver.cc

+++ b/net/tools/testserver/run_testserver.cc

@@ -9,6 +9,7 @@

#include "base/files/file_path.h"

#include "base/logging.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/utf_string_conversions.h"

#include "base/test/test_timeouts.h"

#include "net/test/spawned_test_server/spawned_test_server.h"

@@ -121,6 +122,6 @@ int main(int argc, const char* argv[]) {

printf("testserver running at %s (type ctrl+c to exit)\n",

test_server->host_port_pair().ToString().c_str());

- message_loop.Run();

+ base::RunLoop().Run();

agl 2016/08/06 00:44:00 Should the |message_loop| variable be removed?

fdoray 2016/08/06 01:26:14 No. It needs to exist. Throughout its lifetime, a

return 0;

}