components/sync_sessions/favicon_cache_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_sessions/favicon_cache_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync/tools/testserver/run_sync_testserver.cc ('K') | « components/sync_driver/ui_data_type_controller_unittest.cc ('k') | content/browser/appcache/chrome_appcache_service_unittest.cc » ('j') | net/tools/get_server_time/get_server_time.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_sessions/favicon_cache_unittest.cc

diff --git a/components/sync_sessions/favicon_cache_unittest.cc b/components/sync_sessions/favicon_cache_unittest.cc

index 8b3a3ac29d331295d654e001b3b46813961a2f08..b93e6887429ed96b944889a9953a6f44c2e3452c 100644

--- a/components/sync_sessions/favicon_cache_unittest.cc

+++ b/components/sync_sessions/favicon_cache_unittest.cc

@@ -10,6 +10,7 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

@@ -456,7 +457,7 @@ void SyncFaviconCacheTest::TriggerSyncFaviconReceived(

icon_url,

icon_bytes,

last_visit_time_ms);

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

// A freshly constructed cache should be empty.