DevTools security panel: refresh explanations when clearing origins

DevTools security panel: refresh explanations when clearing origins

When the main frame navigates, the security panel clears the filtered
request counts (the counts of blocked and allowed mixed
content). Previously, we weren't refreshing the explanations after doing
so, meaning that some of the mixed content explanations persisted across
navigations.

BUG=601944
Committed: https://crrev.com/06c60d09f0a9ee1f66ce7ac0b68ff1c38a5f563d
Cr-Commit-Position: refs/heads/master@{#410408}

[estark, 2016-08-06 19:50:07]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 19:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-08-06 19:59:47]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 19:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 21:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 21:28:35]

Dry run: This issue passed the CQ dry run.

[estark, 2016-08-08 05:05:14]

estark@chromium.org changed reviewers:
+ dgozman@chromium.org

[estark, 2016-08-08 05:05:14]

dgozman, PTAL?

[dgozman, 2016-08-08 15:42:13]

lgtm

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:270:
_clearOrigins: function()
Can we inline this function into _onMainFrameNavigated?

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:285:
_onMainFrameNavigated: function(event) {
style: and put { on next line?

[estark, 2016-08-08 16:53:05]

Thanks!

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
(right):

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:270:
_clearOrigins: function()
On 2016/08/08 15:42:13, dgozman wrote:
> Can we inline this function into _onMainFrameNavigated?

Done.

https://codereview.chromium.org/2211413005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js:285:
_onMainFrameNavigated: function(event) {
On 2016/08/08 15:42:13, dgozman wrote:
> style: and put { on next line?

Done.

[estark, 2016-08-08 16:53:11]

The CQ bit was checked by estark@chromium.org

[estark, 2016-08-08 16:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2211413005/#ps40001
(title: "dgozman comments")

[commit-bot: I haz the power, 2016-08-08 16:53:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:04:19]

Description was changed from

==========
DevTools security panel: refresh explanations when clearing origins

When the main frame navigates, the security panel clears the filtered
request counts (the counts of blocked and allowed mixed
content). Previously, we weren't refreshing the explanations after doing
so, meaning that some of the mixed content explanations persisted across
navigations.

BUG=601944
==========

to

==========
DevTools security panel: refresh explanations when clearing origins

When the main frame navigates, the security panel clears the filtered
request counts (the counts of blocked and allowed mixed
content). Previously, we weren't refreshing the explanations after doing
so, meaning that some of the mixed content explanations persisted across
navigations.

BUG=601944

Committed: https://crrev.com/06c60d09f0a9ee1f66ce7ac0b68ff1c38a5f563d
Cr-Commit-Position: refs/heads/master@{#410408}
==========

[commit-bot: I haz the power, 2016-08-08 20:04:21]

Patchset 3 (id:??) landed as
https://crrev.com/06c60d09f0a9ee1f66ce7ac0b68ff1c38a5f563d
Cr-Commit-Position: refs/heads/master@{#410408}