Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2211413005: DevTools security panel: refresh explanations when clearing origins (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: dgozman comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
index 24bf68ab3b9b6738ee320d533de99f1c7c213917..3c115cdcbddcd7f456a7f3abc6133ad92e0ef443 100644
--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js
@@ -267,24 +267,23 @@ WebInspector.SecurityPanel.prototype = {
{
},
- _clearOrigins: function()
- {
- this.selectAndSwitchToMainView();
- this._sidebarTree.clearOrigins();
- this._origins.clear();
- this._lastResponseReceivedForLoaderId.clear();
- this._filterRequestCounts.clear();
- },
-
/**
* @param {!WebInspector.Event} event
*/
- _onMainFrameNavigated: function(event) {
-
+ _onMainFrameNavigated: function(event)
+ {
var frame = /** type {!PageAgent.Frame}*/ (event.data);
var request = this._lastResponseReceivedForLoaderId.get(frame.loaderId);
- this._clearOrigins();
+ // Clear the origins list.
+ this.selectAndSwitchToMainView();
+ this._sidebarTree.clearOrigins();
+ this._origins.clear();
+ this._lastResponseReceivedForLoaderId.clear();
+ this._filterRequestCounts.clear();
+ // After clearing the filtered request counts, refresh the
+ // explanations to reflect the new counts.
+ this._mainView.refreshExplanations();
if (request) {
var origin = WebInspector.ParsedURL.extractOrigin(request.url);
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-blocked-mixed-content-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698