Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2211393003: Revert of Hook up compiler dispatcher jobs to lazy parser. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Hook up compiler dispatcher jobs to lazy parser. (patchset #3 id:40001 of https://codereview.chromium.org/2220463002/ ) Reason for revert: Need to revert https://codereview.chromium.org/2216563003 - just reland rebased version Original issue's description: > Hook up compiler dispatcher jobs to lazy parser. > > The lazy parser actually parses eagerly. It's called lazy because it > parses functions that were previously lazy parsed. D'uh. > > BUG=v8:5215 > R=marja@chromium.org > > Committed: https://crrev.com/255cc15f98507e2bba49574f4dc38c74deb0ca2c > Cr-Commit-Position: refs/heads/master@{#38375} TBR=marja@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Committed: https://crrev.com/e0ac9a1e3c865c3f6844b6c90aed2f940a04634b Cr-Commit-Position: refs/heads/master@{#38378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -75 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/parsing/parser.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/parsing/parser.cc View 6 chunks +6 lines, -11 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 3 chunks +1 line, -43 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Hook up compiler dispatcher jobs to lazy parser.
4 years, 4 months ago (2016-08-05 12:33:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211393003/1
4 years, 4 months ago (2016-08-05 12:33:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:34:02 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:37:29 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0ac9a1e3c865c3f6844b6c90aed2f940a04634b
Cr-Commit-Position: refs/heads/master@{#38378}

Powered by Google App Engine
This is Rietveld 408576698