third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt - Issue 2211283004: Drop test-only WebFrameClient params/functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/plugins/renderer/webview_plugin.h ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/sync-xhr-priority-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/misc/resources/image-slow-out-of-viewport.pl » ('j') | third_party/WebKit/LayoutTests/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt

diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt b/third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt

index b4f92515d9f929b5a35366b28d310ae0fae5cf50..7fd84a7911500694c32c32d97011727e2baa0a09 100644

--- a/third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt

+++ b/third_party/WebKit/LayoutTests/http/tests/misc/favicon-loads-with-images-disabled-expected.txt

@@ -1,6 +1,5 @@

-http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html, main document URL http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html, http method GET> redirectResponse (null)

+http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html, main document URL http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html, http method GET>

http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html, http status code 200>

-http://127.0.0.1:8000/misc/favicon-loads-with-images-disabled.html - didFinishLoading

Radar 6973106 and https://bugs.webkit.org/show_bug.cgi?id=27896 - Favicons still load when automatic image loading is disabled.

This test uses DRT's resource load delegate callback mode to see if the favicon is loaded even when image loading is off.