Drop test-only WebFrameClient params/functions

components/plugins/renderer/webview_plugin.h

Index: components/plugins/renderer/webview_plugin.h
diff --git a/components/plugins/renderer/webview_plugin.h b/components/plugins/renderer/webview_plugin.h
index c4625e9f11ddd25322db75ba2ea64f644975dcb9..f73df622784cc8fee3c832abb10030893197a951 100644
--- a/components/plugins/renderer/webview_plugin.h
+++ b/components/plugins/renderer/webview_plugin.h
@@ -108,7 +108,7 @@ class WebViewPlugin : public blink::WebPlugin,
       const blink::WebInputEvent& event,
       blink::WebCursorInfo& cursor_info) override;
 
-  void didReceiveResponse(const blink::WebURLResponse& response) override;
+  void didReceiveResponse(const blink::WebURLResponse& response) override {}
   void didReceiveData(const char* data, int data_length) override;
   void didFinishLoading() override;
   void didFailLoading(const blink::WebURLError& error) override;
@@ -137,13 +137,6 @@ class WebViewPlugin : public blink::WebPlugin,
   // WebFrameClient methods:
   void didClearWindowObject(blink::WebLocalFrame* frame) override;
 
-  // This method is defined in WebPlugin as well as in WebFrameClient, but with

[Nate Chapin, 2016/08/10 23:42:14]

WebPlugin::didReceiveResponse and WebFrameClient::didReceiveResponse now have
the same parameters, causing inheritance confusion. However, the response
WebViewPlugin wants (the one provided in a WebPluginClient::didReceiveResponse
callback) is guaranteed to be the committed DocumentLoader/WebDataSource's
response. Use that directly in WebViewPlugin::ReplayReceivedData instead of
listening to the didReceiveResponse callback.

-  // different parameters. We only care about implementing the WebPlugin
-  // version, so we implement this method and call the default in WebFrameClient
-  // (which does nothing) to correctly overload it.
-  void didReceiveResponse(unsigned identifier,
-                          const blink::WebURLResponse& response) override;
-
  private:
   friend class base::DeleteHelper<WebViewPlugin>;
   WebViewPlugin(content::RenderView* render_view,
@@ -176,7 +169,6 @@ class WebViewPlugin : public blink::WebPlugin,
   blink::WebFrame* web_frame_;
   gfx::Rect rect_;
 
-  blink::WebURLResponse response_;
   std::list<std::string> data_;
   std::unique_ptr<blink::WebURLError> error_;
   blink::WebString old_title_;