Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/test_runner/web_frame_test_client.h

Issue 2211283004: Drop test-only WebFrameClient params/functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/web_frame_test_client.h
diff --git a/components/test_runner/web_frame_test_client.h b/components/test_runner/web_frame_test_client.h
index 4bc8e405b1b5e6354a6d9b4fdd90936085a899ab..46e47536fdc76ca1192f35e7b606b7145b3fdf61 100644
--- a/components/test_runner/web_frame_test_client.h
+++ b/components/test_runner/web_frame_test_client.h
@@ -89,16 +89,8 @@ class WebFrameTestClient : public blink::WebFrameClient {
bool did_block_entire_page) override;
void didDispatchPingLoader(const blink::WebURL& url) override;
void willSendRequest(blink::WebLocalFrame* frame,
- unsigned identifier,
- blink::WebURLRequest& request,
- const blink::WebURLResponse& redirect_response) override;
- void didReceiveResponse(unsigned identifier,
- const blink::WebURLResponse& response) override;
- void didChangeResourcePriority(unsigned identifier,
- const blink::WebURLRequest::Priority& priority,
- int intra_priority_value) override;
- void didFinishResourceLoad(blink::WebLocalFrame* frame,
- unsigned identifier) override;
+ blink::WebURLRequest& request) override;
+ void didReceiveResponse(const blink::WebURLResponse& response) override;
blink::WebNavigationPolicy decidePolicyForNavigation(
const blink::WebFrameClient::NavigationPolicyInfo& info) override;
void checkIfAudioSinkExistsAndIsAuthorized(
@@ -116,11 +108,6 @@ class WebFrameTestClient : public blink::WebFrameClient {
WebViewTestProxyBase* web_view_test_proxy_base_;
WebFrameTestProxyBase* web_frame_test_proxy_base_;
- // Map from request identifier into resource url description. The map is used
- // to track resource requests spanning willSendRequest, didReceiveResponse,
- // didChangeResourcePriority, didFinishResourceLoad.
- std::map<unsigned, std::string> resource_identifier_map_;
-
DISALLOW_COPY_AND_ASSIGN(WebFrameTestClient);
};

Powered by Google App Engine
This is Rietveld 408576698