Issue 2211073002: Dismissing suggestion window upon receiving BACK key.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2211073002: Dismissing suggestion window upon receiving BACK key. (Closed)

Created:
4 years, 4 months ago by Ted C

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Dismissing suggestion window upon receiving BACK key. Currently Tab is consuming the device BACK key even when suggestion window is visible and doing page navigation instead of dismissing suggestion window. Added changes to consume BACK key at suggestion window, so that it can consume BACK key and execute respective actions. BUG=630633 Review-Url: https://codereview.chromium.org/2174633004 Cr-Commit-Position: refs/heads/master@{#407703} Committed: https://chromium.googlesource.com/chromium/src/+/aca09e059f9b094dcd3999cfa06d7ec8c3f7258f

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -33 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java	View	5 chunks	+1 line, -27 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Ted C

4 years, 4 months ago (2016-08-04 16:46:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aca09e059f9b094dcd3999cfa06d7ec8c3f7258f.