Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2210973002: Fix compile errors ignored by binding aggregations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
index 8a645b3054b53ba530623a130a6a7ed23eefcd65..02816f52f28ed64ff43559a32c2656189138666b 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
@@ -591,6 +591,9 @@ def named_property_getter(interface):
len(method.arguments) == 1 and
str(method.arguments[0].idl_type) == 'DOMString'))
getter.name = getter.name or 'anonymousNamedGetter'
+ # In some cases, a Window type getter may returns a pointer to LocalDOMWindow
haraken 2016/08/04 13:15:05 return
peria 2016/08/04 13:26:15 Acknowledged.
+ if getter.idl_type.name == 'Window':
+ includes.add('core/frame/LocalDOMWindow.h')
haraken 2016/08/04 13:15:05 I'm not sure if this is a right place to add the i
peria 2016/08/04 13:26:15 I discussed with Shiino-san, and found this is not
return getter
except StopIteration:
return None

Powered by Google App Engine
This is Rietveld 408576698