Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2210973002: Fix compile errors ignored by binding aggregations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 try: 584 try:
585 # Find named property getter, if present; has form: 585 # Find named property getter, if present; has form:
586 # getter TYPE [OPTIONAL_IDENTIFIER](DOMString ARG1) 586 # getter TYPE [OPTIONAL_IDENTIFIER](DOMString ARG1)
587 getter = next( 587 getter = next(
588 method 588 method
589 for method in interface.operations 589 for method in interface.operations
590 if ('getter' in method.specials and 590 if ('getter' in method.specials and
591 len(method.arguments) == 1 and 591 len(method.arguments) == 1 and
592 str(method.arguments[0].idl_type) == 'DOMString')) 592 str(method.arguments[0].idl_type) == 'DOMString'))
593 getter.name = getter.name or 'anonymousNamedGetter' 593 getter.name = getter.name or 'anonymousNamedGetter'
594 # In some cases, a Window type getter may returns a pointer to LocalDOMW indow
haraken 2016/08/04 13:15:05 return
peria 2016/08/04 13:26:15 Acknowledged.
595 if getter.idl_type.name == 'Window':
596 includes.add('core/frame/LocalDOMWindow.h')
haraken 2016/08/04 13:15:05 I'm not sure if this is a right place to add the i
peria 2016/08/04 13:26:15 I discussed with Shiino-san, and found this is not
594 return getter 597 return getter
595 except StopIteration: 598 except StopIteration:
596 return None 599 return None
597 600
598 601
599 def named_property_setter(interface): 602 def named_property_setter(interface):
600 try: 603 try:
601 # Find named property setter, if present; has form: 604 # Find named property setter, if present; has form:
602 # setter RETURN_TYPE [OPTIONAL_IDENTIFIER](DOMString ARG1, ARG_TYPE ARG2 ) 605 # setter RETURN_TYPE [OPTIONAL_IDENTIFIER](DOMString ARG1, ARG_TYPE ARG2 )
603 return next( 606 return next(
(...skipping 19 matching lines...) Expand all
623 except StopIteration: 626 except StopIteration:
624 return None 627 return None
625 628
626 629
627 IdlInterface.indexed_property_getter = property(indexed_property_getter) 630 IdlInterface.indexed_property_getter = property(indexed_property_getter)
628 IdlInterface.indexed_property_setter = property(indexed_property_setter) 631 IdlInterface.indexed_property_setter = property(indexed_property_setter)
629 IdlInterface.indexed_property_deleter = property(indexed_property_deleter) 632 IdlInterface.indexed_property_deleter = property(indexed_property_deleter)
630 IdlInterface.named_property_getter = property(named_property_getter) 633 IdlInterface.named_property_getter = property(named_property_getter)
631 IdlInterface.named_property_setter = property(named_property_setter) 634 IdlInterface.named_property_setter = property(named_property_setter)
632 IdlInterface.named_property_deleter = property(named_property_deleter) 635 IdlInterface.named_property_deleter = property(named_property_deleter)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698