Fix compile errors ignored by binding aggregations

Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.

BUG=634231
Committed: https://crrev.com/eb4c3ca5ce05cb31f699401813f0664ee70fda19
Cr-Commit-Position: refs/heads/master@{#409785}

[peria, 2016-08-04 12:54:53]

Description was changed from

==========
Update binding_compiler to pass compile errors

BUG=634231
==========

to

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors.


BUG=634231
==========

[peria, 2016-08-04 12:57:58]

Description was changed from

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors.


BUG=634231
==========

to

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.


BUG=634231
==========

[peria, 2016-08-04 12:59:35]

Patchset #1 (id:1) has been deleted

[peria, 2016-08-04 13:00:13]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, tzik@chromium.org, yukishiino@chromium.org

[peria, 2016-08-04 13:00:14]

PTL.

[haraken, 2016-08-04 13:15:04]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-08-04 13:15:05]

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_utilities.py (right):

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_utilities.py:594: # In some cases,
a Window type getter may returns a pointer to LocalDOMWindow

return

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_utilities.py:596:
includes.add('core/frame/LocalDOMWindow.h')

I'm not sure if this is a right place to add the include. shiino-san?

[peria, 2016-08-04 13:26:15]

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_utilities.py (right):

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_utilities.py:594: # In some cases,
a Window type getter may returns a pointer to LocalDOMWindow
On 2016/08/04 13:15:05, haraken wrote:
> 
> return

Acknowledged.

https://codereview.chromium.org/2210973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_utilities.py:596:
includes.add('core/frame/LocalDOMWindow.h')
On 2016/08/04 13:15:05, haraken wrote:
> 
> I'm not sure if this is a right place to add the include. shiino-san?

I discussed with Shiino-san, and found this is not a right place.
Because IDL tells to use DOMWindow type, the internal class,
HTMLFraceSetElement in this case, must provide the knowledge that
LocalDOMWindow* is acceptable with DOMWindow.

[haraken, 2016-08-04 13:27:33]

PS2 LGTM

[Yuki, 2016-08-04 13:29:55]

lgtm

[peria, 2016-08-04 13:30:15]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2016-08-04 13:30:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 15:02:46]

Description was changed from

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.


BUG=634231
==========

to

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.


BUG=634231
==========

[commit-bot: I haz the power, 2016-08-04 15:02:47]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-04 15:04:00]

Description was changed from

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.


BUG=634231
==========

to

==========
Fix compile errors ignored by binding aggregations

In binding layer, we compile many .cpp file at once,
aggregated into few .cpp files.
This aggregation hides some lacks of dependency, and
it strongly dependent on current aggregation style.
(For example, crrev.com/2216563002 makes it obvious)

This CL fixes those hidden compile errors in generated code.

BUG=634231

Committed: https://crrev.com/eb4c3ca5ce05cb31f699401813f0664ee70fda19
Cr-Commit-Position: refs/heads/master@{#409785}
==========

[commit-bot: I haz the power, 2016-08-04 15:04:01]

Patchset 2 (id:??) landed as
https://crrev.com/eb4c3ca5ce05cb31f699401813f0664ee70fda19
Cr-Commit-Position: refs/heads/master@{#409785}