Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2210743002: Merge layout tests checkValidity-00n.html into one. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge layout tests checkValidity-00n.html into one. Also testcases duplicated with WPT are removed. This CL has no behavior changes. Committed: https://crrev.com/35ff3af8113ab538f19bbb1be7cf73fb68aec9a6 Cr-Commit-Position: refs/heads/master@{#410001}

Patch Set 1 #

Patch Set 2 : Build HTML tree in each of tests #

Messages

Total messages: 20 (13 generated)
tkent
yosin@, would you review this please?
4 years, 4 months ago (2016-08-04 01:38:49 UTC) #7
tkent
Patch Set 2 has a change similar to Patch Set 2 of https://codereview.chromium.org/2211743003 .
4 years, 4 months ago (2016-08-04 23:09:11 UTC) #12
tkent
oops, typo in mail address. yosin, can you review this?
4 years, 4 months ago (2016-08-05 05:33:47 UTC) #14
yosin_UTC9
lgtm
4 years, 4 months ago (2016-08-05 06:06:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210743002/20001
4 years, 4 months ago (2016-08-05 06:06:35 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 06:10:07 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 06:12:24 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35ff3af8113ab538f19bbb1be7cf73fb68aec9a6
Cr-Commit-Position: refs/heads/master@{#410001}

Powered by Google App Engine
This is Rietveld 408576698