Merge layout tests ValidityState-valueMissing-00N.html into one.

Merge layout tests ValidityState-valueMissing-00N.html into one.

This CL has no behavior changes.

Committed: https://crrev.com/9bc477c8735aeacde83b2cf91d08c6e8f7c0e368
Cr-Commit-Position: refs/heads/master@{#409960}

[tkent, 2016-08-04 06:44:04]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 06:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-04 07:17:21]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-08-04 07:17:21]

yosin@, would you review this please?

[commit-bot: I haz the power, 2016-08-04 07:48:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 07:48:01]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-08-04 08:19:20]

https://codereview.chromium.org/2211743003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/ValidityState-valueMissing.html
(right):

https://codereview.chromium.org/2211743003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/ValidityState-valueMissing.html:179:
assert_true(valueMissingFor('input-empty'));
Since sample and verification is too far away, it is hard to debug test case.

Can we create sample HTML here?

Example:
test(() => {
  assert_true(valueMissingFor('<input name="victim" required/>'));
}, 'Empty-value INPUT[required] should be valueMissing.');

// We have "sample" div at end of body
function valueMissingFor(html) 
{
  var sample = document.getElementById('sample');
  sample.innerHTML = html;
  var control = sample.firstChild;
  return control.validity.valueMissing;
}

[tkent, 2016-08-04 12:19:18]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 12:19:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-04 12:29:24]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 12:29:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 13:32:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 13:32:29]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-04 14:24:01]

Patchset #2 (id:20001) has been deleted

[tkent, 2016-08-04 23:08:26]

https://codereview.chromium.org/2211743003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/ValidityState-valueMissing.html
(right):

https://codereview.chromium.org/2211743003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/ValidityState-valueMissing.html:179:
assert_true(valueMissingFor('input-empty'));
On 2016/08/04 at 08:19:19, Yosi_UTC9 wrote:
> Since sample and verification is too far away, it is hard to debug test case.
> 
> Can we create sample HTML here?
> 
> Example:
> test(() => {
>   assert_true(valueMissingFor('<input name="victim" required/>'));
> }, 'Empty-value INPUT[required] should be valueMissing.');
> 
> // We have "sample" div at end of body
> function valueMissingFor(html) 
> {
>   var sample = document.getElementById('sample');
>   sample.innerHTML = html;
>   var control = sample.firstChild;
>   return control.validity.valueMissing;
> }

That's a good idea.  Done in Patch Set 2.

[yosin_UTC9, 2016-08-05 01:20:46]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-08-05 01:20:46]

lgtm

lgtm

Awesome!
It is easy to read and maintain. (^_^)b

[commit-bot: I haz the power, 2016-08-05 01:21:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 01:25:25]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-05 01:26:33]

Description was changed from

==========
Merge layout tests ValidityState-valueMissing-00N.html into one.

This CL has no behavior changes.
==========

to

==========
Merge layout tests ValidityState-valueMissing-00N.html into one.

This CL has no behavior changes.

Committed: https://crrev.com/9bc477c8735aeacde83b2cf91d08c6e8f7c0e368
Cr-Commit-Position: refs/heads/master@{#409960}
==========

[commit-bot: I haz the power, 2016-08-05 01:26:34]

Patchset 2 (id:??) landed as
https://crrev.com/9bc477c8735aeacde83b2cf91d08c6e8f7c0e368
Cr-Commit-Position: refs/heads/master@{#409960}