Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2210573002: browser_test: Add a browser_tests_runner target for running tests. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

browser_test: Add a browser_tests_runner target for running tests. browser_tests_main.cc file is used to run the tests in browser_tests, chromevox_tests, and sync_integration_tests. Create a separate browser_tests_runner target, and use that instead for these tests. BUG=634021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd Cr-Commit-Position: refs/heads/master@{#409610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -25 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +35 lines, -23 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
sadrul
4 years, 4 months ago (2016-08-03 17:16:41 UTC) #5
sky
LGTM
4 years, 4 months ago (2016-08-03 20:04:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210573002/1
4 years, 4 months ago (2016-08-03 20:15:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 20:20:44 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 20:23:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e94d5d32a4a742c26d4e7f9eb537da2a19f1d4cd
Cr-Commit-Position: refs/heads/master@{#409610}

Powered by Google App Engine
This is Rietveld 408576698