Remove MOJO_SHELL_CLIENT define.

Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/943e3b3d3c21264c8df5d7028e5ab4cc57b3f9af
Cr-Commit-Position: refs/heads/master@{#409839}

[sadrul, 2016-08-03 03:52:29]

Description was changed from

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
==========

to

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[sadrul, 2016-08-03 03:53:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 03:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 03:57:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 03:57:34]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sadrul, 2016-08-03 04:51:12]

Patchset #2 (id:20001) has been deleted

[sadrul, 2016-08-03 04:52:10]

Description was changed from

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation
==========

[sadrul, 2016-08-03 04:53:20]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 04:53:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 05:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 05:09:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-08-03 17:16:54]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2016-08-03 20:18:39]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 20:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:22:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sadrul, 2016-08-03 20:41:34]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 20:42:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:49:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:49:37]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Ben Goodger (Google), 2016-08-04 14:43:36]

lgtm, but see note below:

https://codereview.chromium.org/2208613002/diff/80001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2208613002/diff/80001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:271: #if defined(USE_AURA)
So you're actually reducing the # of places this stuff is built. How about not
guarding it? It's not that much code. It's not immediately apparent why it's
USE_AURA specific.

[sadrul, 2016-08-04 14:47:43]

https://codereview.chromium.org/2208613002/diff/80001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/2208613002/diff/80001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:271: #if defined(USE_AURA)
On 2016/08/04 14:43:36, Ben Goodger (Google) wrote:
> So you're actually reducing the # of places this stuff is built. How about not
> guarding it? It's not that much code. It's not immediately apparent why it's
> USE_AURA specific.

MOJO_SHELL_CLIENT is currently defined (and the dependency on services/ui added)
only for use_aura
(https://cs.chromium.org/chromium/src/chrome/browser/BUILD.gn?sq=package:chrom...).
I can turn it on for all platforms, but I'll do that in a separate CL?

[sadrul, 2016-08-04 16:21:29]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 16:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-04 16:57:21]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-08-04 16:57:22]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2208613002/#ps100001
(title: "tot merge")

[commit-bot: I haz the power, 2016-08-04 16:58:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 18:23:19]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-04 18:25:36]

Description was changed from

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove MOJO_SHELL_CLIENT define.

MOJO_SHELL_CLIENT was defined only for gn builds. Now that gn is the default
on all platforms, remove this define. In some targets, MOJO_SHELL_CLIENT was
defined only for aura platforms. Replace MOJO_SHELL_CLIENT check with check
for USE_AURA instead in those targets.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/943e3b3d3c21264c8df5d7028e5ab4cc57b3f9af
Cr-Commit-Position: refs/heads/master@{#409839}
==========

[commit-bot: I haz the power, 2016-08-04 18:25:38]

Patchset 5 (id:??) landed as
https://crrev.com/943e3b3d3c21264c8df5d7028e5ab4cc57b3f9af
Cr-Commit-Position: refs/heads/master@{#409839}