Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2210563002:
Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 (Closed)
DescriptionRoll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1
Committed: https://pdfium.googlesource.com/pdfium/+/d9a39d0e09df7f09d0f6caec525642f3472fe6f3
Patch Set 1 #Patch Set 2 : Roll skia forward #Messages
Total messages: 18 (6 generated)
msarett@google.com changed reviewers: + thestig@chromium.org
Is https://codereview.chromium.org/2206663002 going to get reverted? (Someone complained) Also, strangely codereview shows a 'D' but the file is actually still there, but empty. https://skia.googlesource.com/skia.git/+/a25f470bc7bef67e7b0486efabf8cbf60a06... Also, we won't need this until PDFium rolls DEPS for Skia. Right now, PDFium is still using an older revision. https://pdfium.googlesource.com/pdfium/+/master/DEPS
On 2016/08/03 16:13:23, Lei Zhang wrote: > Is https://codereview.chromium.org/2206663002 going to get reverted? (Someone > complained) > No, I've fixed the build problems in Android. > Also, strangely codereview shows a 'D' but the file is actually still there, but > empty. > https://skia.googlesource.com/skia.git/+/a25f470bc7bef67e7b0486efabf8cbf60a06... > I needed to leave the empty file (until I modify BUILD.gn in Chrome and possibly here) otherwise the skia roll into Chrome will break. > Also, we won't need this until PDFium rolls DEPS for Skia. Right now, PDFium is > still using an older revision. > https://pdfium.googlesource.com/pdfium/+/master/DEPS Got it. Didn't realize that skia does not roll continuously into pdfium. Maybe we just leave this here until we need it?
On 2016/08/03 16:16:39, msarett wrote: > Got it. Didn't realize that skia does not roll continuously into pdfium. Maybe > we just leave this here until we need it? PDFium does it all manually. We can do a roll here if you'd like. Skia is not enabled by default yet, so if it breaks, it only affects Cary, who is probably OOO right now anyway. ;)
On 2016/08/03 16:26:38, Lei Zhang wrote: > On 2016/08/03 16:16:39, msarett wrote: > > Got it. Didn't realize that skia does not roll continuously into pdfium. > Maybe > > we just leave this here until we need it? > > PDFium does it all manually. We can do a roll here if you'd like. Skia is not > enabled by default yet, so if it breaks, it only affects Cary, who is probably > OOO right now anyway. ;) Sounds good. You're right, Cary is OOO right now, I'll discuss with him when he gets back.
Description was changed from ========== Remove BUILD.gn reference to deleted skia file BUG= ========== to ========== Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 BUG= ==========
msarett@google.com changed reviewers: + caryclark@google.com
Ahh ok, so it turns out that we have test bot that continually checks the roll into pdfium. And now I've broken it. https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu... Can we go ahead and land this along with rolling Skia forward?
On 2016/08/03 18:41:29, msarett wrote: > Ahh ok, so it turns out that we have test bot that > continually checks the roll into pdfium. > > And now I've broken it. > https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu... > > Can we go ahead and land this along with rolling Skia > forward? Ya, go ahead and roll DEPS.
On 2016/08/03 18:54:09, Lei Zhang wrote: > On 2016/08/03 18:41:29, msarett wrote: > > Ahh ok, so it turns out that we have test bot that > > continually checks the roll into pdfium. > > > > And now I've broken it. > > > https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu... > > > > Can we go ahead and land this along with rolling Skia > > forward? > > Ya, go ahead and roll DEPS. I've included the roll in this CL. PTAL.
Description was changed from ========== Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 BUG= ========== to ========== Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 ==========
LGTM. I removed the empty BUG= line.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/03 18:58:27, Lei Zhang wrote: > LGTM. > > I removed the empty BUG= line. Thanks!
Message was sent while issue was closed.
Description was changed from ========== Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 ========== to ========== Roll skia to 96206a96f357cd30b60d1b1aa98e4e3a8f9b97f1 Committed: https://pdfium.googlesource.com/pdfium/+/d9a39d0e09df7f09d0f6caec525642f3472f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/d9a39d0e09df7f09d0f6caec525642f3472f... |
