Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2210533004: Revert of Do not calculate composition bounds until IME requests. (Closed)

Created:
4 years, 4 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 4 months ago
CC:
Changwan Ryu, chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, yosin_UTC9
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not calculate composition bounds until IME requests. (patchset #11 id:720001 of https://codereview.chromium.org/2121953002/ ) Reason for revert: CursorAnchorInfoControllerTest.testMonitorMode consistently failing on downstream lollipop bots (and I also see the same failure in the trybots for patchset 11, I don't understand why CQ let this through...). BUG=633402 Original issue's description: > Do not calculate composition bounds until IME requests. > > Calculating composition bounds is not a light-weight operation. > On the other hand, few IME uses this information. > To skip this unnecessary calculation on certain environment, propagate > cursor update mode from browser to the renderer. > > BUG=624714 > > Committed: https://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b > Cr-Commit-Position: refs/heads/master@{#408900} TBR=changwan@chromium.org,kinaba@chromium.org,shuchen@chromium.org,yosin@chromium.org,yukawa@chromium.org,nasko@chromium.org,nona@chromium.org NOTRY=true BUG=624714 Committed: https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3 Cr-Commit-Position: refs/heads/master@{#409901}

Patch Set 1 #

Messages

Total messages: 14 (7 generated)
aelias_OOO_until_Jul13
Created Revert of Do not calculate composition bounds until IME requests.
4 years, 4 months ago (2016-08-04 19:46:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210533004/1
4 years, 4 months ago (2016-08-04 19:47:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204414)
4 years, 4 months ago (2016-08-04 20:28:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210533004/1
4 years, 4 months ago (2016-08-04 20:51:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210533004/1
4 years, 4 months ago (2016-08-04 20:53:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 21:15:40 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:17:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b24cbc456753503ec0f499c890acae6a5a2e3cc3
Cr-Commit-Position: refs/heads/master@{#409901}

Powered by Google App Engine
This is Rietveld 408576698