Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2210503002:
Get rid of the timeouts in CredentialManagerBrowserTest.* (Closed)
|
Created:
4 years, 4 months ago by vasilii Modified:
4 years, 4 months ago Reviewers:
kolos1 CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGet rid of the timeouts in CredentialManagerBrowserTest.*
After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile().
BUG=631958
Committed: https://crrev.com/620ba75d0ad297a1a9ddfc6a35330c4128122fa6
Cr-Commit-Position: refs/heads/master@{#409754}
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Get rid of the timeouts in CredentialManagerBrowserTest.* BUG=631958 ========== to ========== Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG=631958 ==========
vasilii@chromium.org changed reviewers: + kolos@chromium.org
Hi Maxim, please review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM. Has one comment. https://codereview.chromium.org/2210503002/diff/1/chrome/browser/password_man... File chrome/browser/password_manager/credential_manager_browsertest.cc (right): https://codereview.chromium.org/2210503002/diff/1/chrome/browser/password_man... chrome/browser/password_manager/credential_manager_browsertest.cc:160: // because it was suppressed when the site fot the credential back. fot->got?
The CQ bit was checked by vasilii@chromium.org to run a CQ dry run
https://codereview.chromium.org/2210503002/diff/1/chrome/browser/password_man... File chrome/browser/password_manager/credential_manager_browsertest.cc (right): https://codereview.chromium.org/2210503002/diff/1/chrome/browser/password_man... chrome/browser/password_manager/credential_manager_browsertest.cc:160: // because it was suppressed when the site fot the credential back. On 2016/08/04 09:18:34, kolos1 wrote: > fot->got? Done.
The CQ bit was unchecked by vasilii@chromium.org
The CQ bit was checked by vasilii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kolos@chromium.org Link to the patchset: https://codereview.chromium.org/2210503002/#ps20001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG=631958 ========== to ========== Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG=631958 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG=631958 ========== to ========== Get rid of the timeouts in CredentialManagerBrowserTest.* After https://codereview.chromium.org/2189513004 there is no need in workarounds. PasswordManager should process all the forms inside NavigateToFile(). BUG=631958 Committed: https://crrev.com/620ba75d0ad297a1a9ddfc6a35330c4128122fa6 Cr-Commit-Position: refs/heads/master@{#409754} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/620ba75d0ad297a1a9ddfc6a35330c4128122fa6 Cr-Commit-Position: refs/heads/master@{#409754}
Message was sent while issue was closed.
\o/ Great to see the timeouts gone and the tests to become faster and decrease the potential for flakiness! |
