Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2189513004: Blink: prevent didAssociateFormControls notification while parsing the document. (Closed)

Created:
4 years, 4 months ago by vasilii
Modified:
4 years, 4 months ago
Reviewers:
tkent, vabr (Chromium), sky
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, estade+watch_chromium.org, gavinp+loader_chromium.org, gcasto+watchlist_chromium.org, jam, Nate Chapin, jdonnelly+autofillwatch_chromium.org, kinuko+watch, loading-reviews_chromium.org, mlamouri+watch-content_chromium.org, rwlbuis, rouslan+autofill_chromium.org, sof, tyoshino+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink: prevent didAssociateFormControls notification while parsing the document. Also remove Document::m_associatedFormControls unused by the consumer. BUG=631958 Committed: https://crrev.com/c7e3c1f85c4691489409104d9ab53d30b52cd8d9 Cr-Commit-Position: refs/heads/master@{#408388}

Patch Set 1 #

Total comments: 4

Patch Set 2 : change comment #

Total comments: 2

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -40 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 1 chunk +10 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 4 chunks +3 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebAutofillClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (17 generated)
vasilii
Hi guys, please review the CL.
4 years, 4 months ago (2016-07-27 13:46:04 UTC) #4
vabr (Chromium)
LGTM, thanks! Vaclav https://codereview.chromium.org/2189513004/diff/1/chrome/browser/password_manager/password_manager_browsertest.cc File chrome/browser/password_manager/password_manager_browsertest.cc (right): https://codereview.chromium.org/2189513004/diff/1/chrome/browser/password_manager/password_manager_browsertest.cc#newcode209 chrome/browser/password_manager/password_manager_browsertest.cc:209: NoPromptIfPasswordFormManagerDestroyed) { Just a note: One ...
4 years, 4 months ago (2016-07-27 14:06:50 UTC) #5
vasilii
Scott, please review chrome/test/base/chrome_render_view_test.cc https://codereview.chromium.org/2189513004/diff/1/chrome/browser/password_manager/password_manager_browsertest.cc File chrome/browser/password_manager/password_manager_browsertest.cc (right): https://codereview.chromium.org/2189513004/diff/1/chrome/browser/password_manager/password_manager_browsertest.cc#newcode209 chrome/browser/password_manager/password_manager_browsertest.cc:209: NoPromptIfPasswordFormManagerDestroyed) { On 2016/07/27 14:06:49, ...
4 years, 4 months ago (2016-07-27 14:26:59 UTC) #10
vabr (Chromium)
Thanks for answers, still LGTM!
4 years, 4 months ago (2016-07-27 14:28:44 UTC) #11
sky
LGTM
4 years, 4 months ago (2016-07-27 15:30:47 UTC) #12
tkent
Let's rename ChromeClient::didAssociateFormControls and WebAutofillClient::didAssociateFormControls to didAssociateFormControlsAfterLoad, didAssociateFormControlsAfterParsing, didAssociateFormControlsDynamically, or something. https://codereview.chromium.org/2189513004/diff/20001/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): ...
4 years, 4 months ago (2016-07-28 00:21:24 UTC) #15
vasilii
Renamed. https://codereview.chromium.org/2189513004/diff/20001/third_party/WebKit/Source/core/dom/Document.cpp File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2189513004/diff/20001/third_party/WebKit/Source/core/dom/Document.cpp#newcode5740 third_party/WebKit/Source/core/dom/Document.cpp:5740: if (!frame() || !frame()->page() || !hasFinishedParsing()) On 2016/07/28 ...
4 years, 4 months ago (2016-07-28 12:38:50 UTC) #18
tkent
lgtm
4 years, 4 months ago (2016-07-28 14:17:47 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189513004/40001
4 years, 4 months ago (2016-07-28 14:26:09 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-28 14:29:59 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 14:31:30 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c7e3c1f85c4691489409104d9ab53d30b52cd8d9
Cr-Commit-Position: refs/heads/master@{#408388}

Powered by Google App Engine
This is Rietveld 408576698