Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209873002: Attempt to fix failures under Windows (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -33 lines) Patch
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 9 chunks +18 lines, -10 lines 4 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 6 chunks +3 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Also some formatting churn and removal of unnecessary comments.
4 years, 4 months ago (2016-08-03 19:56:38 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2209873002/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right): https://codereview.chromium.org/2209873002/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart#newcode120 pkg/analyzer/lib/src/dart/sdk/sdk.dart:120: File file = resourceProvider.getFile(uri.toFilePath(windows: isWindows)); Maybe pathos.fromUri(uri) to ...
4 years, 4 months ago (2016-08-03 20:03:31 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2209873002/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right): https://codereview.chromium.org/2209873002/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart#newcode120 pkg/analyzer/lib/src/dart/sdk/sdk.dart:120: File file = resourceProvider.getFile(uri.toFilePath(windows: isWindows)); Done https://codereview.chromium.org/2209873002/diff/1/pkg/analyzer/lib/src/dart/sdk/sdk.dart#newcode170 pkg/analyzer/lib/src/dart/sdk/sdk.dart:170: libraryPath.lastIndexOf(resourceProvider.pathContext.separator); ...
4 years, 4 months ago (2016-08-03 20:26:32 UTC) #4
Brian Wilkerson
4 years, 4 months ago (2016-08-03 20:26:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9169baca21224912d02a7835d2bc3454130c91b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698