Attempt to fix failures under Windows

pkg/analyzer/test/src/dart/sdk/sdk_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.sdk_test;
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/source/embedder.dart' show EmbedderYamlLocator;
 import 'package:analyzer/src/dart/sdk/sdk.dart';
 import 'package:analyzer/src/generated/engine.dart';
+import 'package:analyzer/src/generated/java_engine_io.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../../generated/test_support.dart';
 import '../../../reflective_tests.dart';
 import '../../../resource_utils.dart';
 import '../../../source/embedder_test.dart';
 import '../../../utils.dart';
 
@@ skipping 66 matching lines @@
   }
 }
 
 @reflectiveTest
 class FolderBasedDartSdkTest {
   /**
    * The resource provider used by these tests.
    */
   MemoryResourceProvider resourceProvider;
 
-//  void test_getDocFileFor() {
-//    FolderBasedDartSdk sdk = _createDartSdk();
-//    File docFile = sdk.getDocFileFor("html");
-//    expect(docFile, isNotNull);
-//  }
-
   void test_analysisOptions_afterContextCreation() {
     FolderBasedDartSdk sdk = _createDartSdk();
     sdk.context;
     expect(() {
       sdk.analysisOptions = new AnalysisOptionsImpl();
     }, throwsStateError);
   }
 
   void test_analysisOptions_beforeContextCreation() {
     FolderBasedDartSdk sdk = _createDartSdk();
@@ skipping 55 matching lines @@
     FolderBasedDartSdk sdk = _createDartSdk();
     Source source = sdk.fromFileUri(sdk.libraryDirectory
         .getChildAssumingFolder("core")
         .getChildAssumingFile("num.dart")
         .toUri());
     expect(source, isNotNull);
     expect(source.isInSystemLibrary, isTrue);
     expect(source.uri.toString(), "dart:core/num.dart");
   }
 
-//  void test_dart2JsExecutable() {
-//    FolderBasedDartSdk sdk = _createDartSdk();
-//    File executable = sdk.dart2JsExecutable;
-//    expect(executable, isNotNull);
-//    expect(executable.exists, isTrue);
-////    expect(executable.isExecutable(), isTrue);
-//  }
-
   void test_getDirectory() {
     FolderBasedDartSdk sdk = _createDartSdk();
     Folder directory = sdk.directory;
     expect(directory, isNotNull);
     expect(directory.exists, isTrue);
   }
 
   void test_getDocDirectory() {
     FolderBasedDartSdk sdk = _createDartSdk();
     Folder directory = sdk.docDirectory;
     expect(directory, isNotNull);
   }
 
   void test_getLibraryDirectory() {
     FolderBasedDartSdk sdk = _createDartSdk();
     Folder directory = sdk.libraryDirectory;
     expect(directory, isNotNull);
     expect(directory.exists, isTrue);
   }
 
   void test_getPubExecutable() {
     FolderBasedDartSdk sdk = _createDartSdk();
     File executable = sdk.pubExecutable;
     expect(executable, isNotNull);
     expect(executable.exists, isTrue);
-//    expect(executable.isExecutable(), isTrue);
   }
 
   void test_getSdkVersion() {
     FolderBasedDartSdk sdk = _createDartSdk();
     String version = sdk.sdkVersion;
     expect(version, isNotNull);
     expect(version.length > 0, isTrue);
   }
 
-//  void test_vmExecutable() {
-//    FolderBasedDartSdk sdk = _createDartSdk();
-//    File executable = sdk.vmExecutable;
-//    expect(executable, isNotNull);
-//    expect(executable.exists, isTrue);
-////    expect(executable.isExecutable(), isTrue);
-//  }
-
   void test_useSummary_afterContextCreation() {
     FolderBasedDartSdk sdk = _createDartSdk();
     sdk.context;
     expect(() {
       sdk.useSummary = true;
     }, throwsStateError);
   }
 
   void test_useSummary_beforeContextCreation() {
     FolderBasedDartSdk sdk = _createDartSdk();
     sdk.useSummary = true;
     sdk.context;
   }
 
   FolderBasedDartSdk _createDartSdk() {
     resourceProvider = new MemoryResourceProvider();
     Folder sdkDirectory = resourceProvider.getFolder('/sdk');
     _createFile(sdkDirectory,
         ['lib', '_internal', 'sdk_library_metadata', 'lib', 'libraries.dart'],
         content: _librariesFileContent());
     _createFile(sdkDirectory, ['bin', 'dart']);
     _createFile(sdkDirectory, ['bin', 'dart2js']);
     _createFile(sdkDirectory, ['bin', 'pub']);
     _createFile(sdkDirectory, ['lib', 'async', 'async.dart']);
     _createFile(sdkDirectory, ['lib', 'core', 'core.dart']);
     _createFile(sdkDirectory, ['lib', 'core', 'num.dart']);
     _createFile(sdkDirectory,
         ['lib', 'html', 'html_common', 'html_common_dart2js.dart']);
     _createFile(sdkDirectory, ['lib', 'html', 'dartium', 'html_dartium.dart']);
+    _createFile(
+        sdkDirectory, ['bin', (OSUtilities.isWindows() ? 'pub.bat' : 'pub')]);
     return new FolderBasedDartSdk(resourceProvider, sdkDirectory);
   }
 
   void _createFile(Folder directory, List<String> segments,
       {String content: ''}) {
     Folder parent = directory;
     int last = segments.length - 1;
     for (int i = 0; i < last; i++) {
       parent = parent.getChildAssumingFolder(segments[i]);
     }
@@ skipping 109 matching lines @@
     expect(second, isNotNull);
     expect(second.category, "Server");
     expect(second.path, "second/second.dart");
     expect(second.shortName, "dart:second");
     expect(second.isDart2JsLibrary, false);
     expect(second.isDocumented, false);
     expect(second.isImplementation, true);
     expect(second.isVmLibrary, false);
   }
 }