Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/save_page_request_unittest.cc
diff --git a/components/offline_pages/background/save_page_request_unittest.cc b/components/offline_pages/background/save_page_request_unittest.cc
index 63b970f2e0fa09268472f0aa855ef242effb7118..68f12feb8c80fe6b417ca52bcab751508a54dda5 100644
--- a/components/offline_pages/background/save_page_request_unittest.cc
+++ b/components/offline_pages/background/save_page_request_unittest.cc
@@ -92,10 +92,43 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
ASSERT_EQ(creation_time, request.creation_time());
ASSERT_EQ(activation_time, request.activation_time());
- // Last attempt time, status and attempt count are updated.
+ // Last attempt time and status are updated.
ASSERT_EQ(base::Time(), request.last_attempt_time());
ASSERT_EQ(1, request.attempt_count());
ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(start_time));
}
-} // offline_pages
+TEST_F(SavePageRequestTest, StartAndAbortRequest) {
+ base::Time creation_time = base::Time::Now();
+ SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
+ kUserRequested);
+ int start_attempt_count = 2;
+ request.set_attempt_count(start_attempt_count);
+
+ base::Time start_time = creation_time + base::TimeDelta::FromHours(3);
+ request.MarkAttemptStarted(start_time);
+
+ // Most things don't change about the request.
+ ASSERT_EQ(kRequestId, request.request_id());
+ ASSERT_EQ(kUrl, request.url());
+ ASSERT_EQ(kClientId, request.client_id());
+ ASSERT_EQ(creation_time, request.creation_time());
+
+ // Attempt time and attempt count will though.
+ ASSERT_EQ(start_time, request.last_attempt_time());
+ ASSERT_EQ(start_attempt_count + 1, request.attempt_count());
+
+ request.MarkAttemptAborted();
+
+ // Again, most things don't change about the request.
+ ASSERT_EQ(kRequestId, request.request_id());
+ ASSERT_EQ(kUrl, request.url());
+ ASSERT_EQ(kClientId, request.client_id());
+ ASSERT_EQ(creation_time, request.creation_time());
+
+ // Last attempt time is updated and attempt count decremented.
+ ASSERT_EQ(base::Time(), request.last_attempt_time());
+ ASSERT_EQ(start_attempt_count, request.attempt_count());
+}
+
+} // namespace offline_pages
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698