components/offline_pages/background/save_page_request.cc - Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/save_page_request.cc

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/save_page_request.h ('k') | components/offline_pages/background/save_page_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/save_page_request.cc

diff --git a/components/offline_pages/background/save_page_request.cc b/components/offline_pages/background/save_page_request.cc

index f9372f340a47373ef44a7cb5940d925d810265e5..e5424d703611034e35a24bc1d32703e5aefb6915 100644

--- a/components/offline_pages/background/save_page_request.cc

+++ b/components/offline_pages/background/save_page_request.cc

@@ -78,4 +78,12 @@ void SavePageRequest::MarkAttemptCompleted() {

last_attempt_time_ = base::Time();

}

+void SavePageRequest::MarkAttemptAborted() {

+ DCHECK_GT(attempt_count_, 0);

+ last_attempt_time_ = base::Time();

+ // TODO(dougarnett): Would be safer if we had two persisted counters

+ // (attempts_started and attempts_completed) rather just one with decrement.

+ --attempt_count_;

} // namespace offline_pages