[Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

components/offline_pages/background/request_queue.h

Index: components/offline_pages/background/request_queue.h
diff --git a/components/offline_pages/background/request_queue.h b/components/offline_pages/background/request_queue.h
index 4c19550d01b27ad7481846121e01157e22195512..4f58d533fe128237feda356bf60c4a501f3580de 100644
--- a/components/offline_pages/background/request_queue.h
+++ b/components/offline_pages/background/request_queue.h
@@ -8,6 +8,7 @@
 #include <stdint.h>
 
 #include <memory>
+#include <string>
 #include <vector>
 
 #include "base/callback.h"
@@ -42,6 +43,18 @@ class RequestQueue {
                              // exist.
   };
 
+  static std::string UpdateRequestResultToString(UpdateRequestResult result) {

[fgorski, 2016/08/04 06:01:34]

Please consider defining this and the method in offliner.h outside of these
files, as they do not belong with these classes. Perhaps the recorder could have
a set of helper methods.
Conversion of enum to string feels like a purely diagnostic function and does
not belong to this or offliner interface.

[dougarnett, 2016/08/04 16:24:38]

Done.

+    switch (result) {
+      case UpdateRequestResult::SUCCESS: return "SUCCESS";
+      case UpdateRequestResult::STORE_FAILURE: return "STORE_FAILURE";
+      case UpdateRequestResult::REQUEST_DOES_NOT_EXIST:
+        return "REQUEST_DOES_NOT_EXIST";
+      default:
+        DCHECK(false);
+        return "";
+    }
+  }
+
   // Callback used for |GetRequests|.
   typedef base::Callback<void(GetRequestsResult,
                               const std::vector<SavePageRequest>&)>