[Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

components/offline_pages/background/request_queue.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_
 
 #include <stdint.h>
 
 #include <memory>
+#include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "components/offline_pages/offline_page_item.h"
 
 namespace offline_pages {
 
 class RequestQueueStore;
@@ skipping 14 matching lines @@
                         // reached a quota of active requests.
   };
 
   enum class UpdateRequestResult {
     SUCCESS,
     STORE_FAILURE,
     REQUEST_DOES_NOT_EXIST,  // Failed to delete the request because it does not
                              // exist.
   };
 
+  static std::string UpdateRequestResultToString(UpdateRequestResult result) {

[fgorski, 2016/08/04 06:01:34]

Please consider defining this and the method in offliner.h outside of these
files, as they do not belong with these classes. Perhaps the recorder could have
a set of helper methods.
Conversion of enum to string feels like a purely diagnostic function and does
not belong to this or offliner interface.

[dougarnett, 2016/08/04 16:24:38]

Done.

+    switch (result) {
+      case UpdateRequestResult::SUCCESS: return "SUCCESS";
+      case UpdateRequestResult::STORE_FAILURE: return "STORE_FAILURE";
+      case UpdateRequestResult::REQUEST_DOES_NOT_EXIST:
+        return "REQUEST_DOES_NOT_EXIST";
+      default:
+        DCHECK(false);
+        return "";
+    }
+  }
+
   // Callback used for |GetRequests|.
   typedef base::Callback<void(GetRequestsResult,
                               const std::vector<SavePageRequest>&)>
       GetRequestsCallback;
 
   // Callback used for |AddRequest|.
   typedef base::Callback<void(AddRequestResult, const SavePageRequest& request)>
       AddRequestCallback;
 
   // Callback used by |UdpateRequest| and |RemoveRequest|.
@@ skipping 48 matching lines @@
 
   // Allows us to pass a weak pointer to callbacks.
   base::WeakPtrFactory<RequestQueue> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestQueue);
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_QUEUE_H_