components/offline_pages/background/request_coordinator.h - Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot complaint for no return value on string mapping methods Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/prerendering_offliner.cc ('K') | « components/offline_pages/background/offliner.h ('k') | components/offline_pages/background/request_coordinator.cc » ('j') | components/offline_pages/background/request_coordinator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.h

diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h

index 24c2183a34de46243d3ccd1c2ca418580abd7636..d1fbef39ecb183cf3375960ab6b7900301a30edc 100644

--- a/components/offline_pages/background/request_coordinator.h

+++ b/components/offline_pages/background/request_coordinator.h

@@ -103,7 +103,10 @@ class RequestCoordinator : public KeyedService {

void AddRequestResultCallback(RequestQueue::AddRequestResult result,

const SavePageRequest& request);

- void UpdateRequestCallback(RequestQueue::UpdateRequestResult result);

+ void UpdateRequestCallback(const ClientId& client_id,

+ RequestQueue::UpdateRequestResult result);

+ void UpdateMultipleRequestCallback(RequestQueue::UpdateRequestResult result);

// Callback from the request picker when it has chosen our next request.

void RequestPicked(const SavePageRequest& request);