chrome/browser/android/offline_pages/prerendering_offliner.cc - Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot complaint for no return value on string mapping methods Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/offline_pages/prerendering_offliner.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.cc b/chrome/browser/android/offline_pages/prerendering_offliner.cc

index 9579bed9e40a19695119b1f96f88eedcdde481f1..d49603193d7ad22f2e84b3af43407d606529a2d8 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner.cc

@@ -109,6 +109,7 @@ bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,

const CompletionCallback& callback) {

if (pending_request_) {

DVLOG(1) << "Already have pending request";

+ DCHECK(false);

fgorski 2016/08/04 06:01:34 nit: this should be DCHECK(!pending_request_.get()

dougarnett 2016/08/04 16:24:38 Done.

return false;

}

« no previous file with comments | « no previous file | components/offline_pages/background/offliner.h » ('j') | components/offline_pages/background/request_coordinator.cc » ('J')