Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/android/offline_pages/prerendering_offliner.cc

Issue 2209813002: [Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybot complaint for no return value on string mapping methods Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 5 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/sys_info.h" 8 #include "base/sys_info.h"
9 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h" 9 #include "chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h"
10 #include "components/offline_pages/background/save_page_request.h" 10 #include "components/offline_pages/background/save_page_request.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // request based on specific save error cases. 102 // request based on specific save error cases.
103 save_status = RequestStatus::SAVE_FAILED; 103 save_status = RequestStatus::SAVE_FAILED;
104 } 104 }
105 completion_callback_.Run(request, save_status); 105 completion_callback_.Run(request, save_status);
106 } 106 }
107 107
108 bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request, 108 bool PrerenderingOffliner::LoadAndSave(const SavePageRequest& request,
109 const CompletionCallback& callback) { 109 const CompletionCallback& callback) {
110 if (pending_request_) { 110 if (pending_request_) {
111 DVLOG(1) << "Already have pending request"; 111 DVLOG(1) << "Already have pending request";
112 DCHECK(false);
fgorski 2016/08/04 06:01:34 nit: this should be DCHECK(!pending_request_.get()
dougarnett 2016/08/04 16:24:38 Done.
112 return false; 113 return false;
113 } 114 }
114 115
115 if (!GetOrCreateLoader()->CanPrerender()) { 116 if (!GetOrCreateLoader()->CanPrerender()) {
116 DVLOG(1) << "Prerendering not allowed/configured"; 117 DVLOG(1) << "Prerendering not allowed/configured";
117 return false; 118 return false;
118 } 119 }
119 120
120 if (!OfflinePageModel::CanSaveURL(request.url())) { 121 if (!OfflinePageModel::CanSaveURL(request.url())) {
121 DVLOG(1) << "Not able to save page for requested url: " << request.url(); 122 DVLOG(1) << "Not able to save page for requested url: " << request.url();
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) { 191 base::android::APPLICATION_STATE_HAS_RUNNING_ACTIVITIES) {
191 DVLOG(1) << "App became active, canceling current offlining request"; 192 DVLOG(1) << "App became active, canceling current offlining request";
192 SavePageRequest* request = pending_request_.get(); 193 SavePageRequest* request = pending_request_.get();
193 Cancel(); 194 Cancel();
194 completion_callback_.Run(*request, 195 completion_callback_.Run(*request,
195 Offliner::RequestStatus::FOREGROUND_CANCELED); 196 Offliner::RequestStatus::FOREGROUND_CANCELED);
196 } 197 }
197 } 198 }
198 199
199 } // namespace offline_pages 200 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698