Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h
index 2a2d07c4506fc40244c0f7e0a3c526ee2480b0de..6a88fd567a8b45086e7ae8f09dcb6bbfeae221da 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h
@@ -54,6 +54,12 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitspeechchange);
+ enum TouchHandlerType {
majidvp 2016/08/03 18:01:06 If this is only used in InputTypeView then it shou
+ None,
+ Blocking,
+ Passive
+ };
+
bool shouldAutocomplete() const final;
// For ValidityState
@@ -393,10 +399,10 @@ private:
unsigned m_parsingInProgress : 1;
unsigned m_valueAttributeWasUpdatedAfterParsing : 1;
unsigned m_canReceiveDroppedFiles : 1;
- unsigned m_hasTouchEventHandler : 1;
unsigned m_shouldRevealPassword : 1;
unsigned m_needsToUpdateViewValue : 1;
unsigned m_isPlaceholderVisible : 1;
+ TouchHandlerType m_hasTouchEventHandler : Blocking;
majidvp 2016/08/03 18:01:06 Why do you need to keep this value as a member var
Member<InputType> m_inputType;
Member<InputTypeView> m_inputTypeView;
// The ImageLoader must be owned by this element because the loader code assumes

Powered by Google App Engine
This is Rietveld 408576698