Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 class CORE_EXPORT HTMLInputElement : public HTMLTextFormControlElement { 48 class CORE_EXPORT HTMLInputElement : public HTMLTextFormControlElement {
49 DEFINE_WRAPPERTYPEINFO(); 49 DEFINE_WRAPPERTYPEINFO();
50 public: 50 public:
51 static HTMLInputElement* create(Document&, HTMLFormElement*, bool createdByP arser); 51 static HTMLInputElement* create(Document&, HTMLFormElement*, bool createdByP arser);
52 ~HTMLInputElement() override; 52 ~HTMLInputElement() override;
53 DECLARE_VIRTUAL_TRACE(); 53 DECLARE_VIRTUAL_TRACE();
54 54
55 DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitspeechchange); 55 DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitspeechchange);
56 56
57 enum TouchHandlerType {
majidvp 2016/08/03 18:01:06 If this is only used in InputTypeView then it shou
58 None,
59 Blocking,
60 Passive
61 };
62
57 bool shouldAutocomplete() const final; 63 bool shouldAutocomplete() const final;
58 64
59 // For ValidityState 65 // For ValidityState
60 bool hasBadInput() const final; 66 bool hasBadInput() const final;
61 bool patternMismatch() const final; 67 bool patternMismatch() const final;
62 bool rangeUnderflow() const final; 68 bool rangeUnderflow() const final;
63 bool rangeOverflow() const final; 69 bool rangeOverflow() const final;
64 bool stepMismatch() const final; 70 bool stepMismatch() const final;
65 bool tooLong() const final; 71 bool tooLong() const final;
66 bool tooShort() const final; 72 bool tooShort() const final;
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-d irty-flag 392 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-d irty-flag
387 unsigned m_dirtyCheckedness : 1; 393 unsigned m_dirtyCheckedness : 1;
388 unsigned m_isIndeterminate : 1; 394 unsigned m_isIndeterminate : 1;
389 unsigned m_isActivatedSubmit : 1; 395 unsigned m_isActivatedSubmit : 1;
390 unsigned m_autocomplete : 2; // AutoCompleteSetting 396 unsigned m_autocomplete : 2; // AutoCompleteSetting
391 unsigned m_hasNonEmptyList : 1; 397 unsigned m_hasNonEmptyList : 1;
392 unsigned m_stateRestored : 1; 398 unsigned m_stateRestored : 1;
393 unsigned m_parsingInProgress : 1; 399 unsigned m_parsingInProgress : 1;
394 unsigned m_valueAttributeWasUpdatedAfterParsing : 1; 400 unsigned m_valueAttributeWasUpdatedAfterParsing : 1;
395 unsigned m_canReceiveDroppedFiles : 1; 401 unsigned m_canReceiveDroppedFiles : 1;
396 unsigned m_hasTouchEventHandler : 1;
397 unsigned m_shouldRevealPassword : 1; 402 unsigned m_shouldRevealPassword : 1;
398 unsigned m_needsToUpdateViewValue : 1; 403 unsigned m_needsToUpdateViewValue : 1;
399 unsigned m_isPlaceholderVisible : 1; 404 unsigned m_isPlaceholderVisible : 1;
405 TouchHandlerType m_hasTouchEventHandler : Blocking;
majidvp 2016/08/03 18:01:06 Why do you need to keep this value as a member var
400 Member<InputType> m_inputType; 406 Member<InputType> m_inputType;
401 Member<InputTypeView> m_inputTypeView; 407 Member<InputTypeView> m_inputTypeView;
402 // The ImageLoader must be owned by this element because the loader code ass umes 408 // The ImageLoader must be owned by this element because the loader code ass umes
403 // that it lives as long as its owning element lives. If we move the loader into 409 // that it lives as long as its owning element lives. If we move the loader into
404 // the ImageInput object we may delete the loader while this element lives o n. 410 // the ImageInput object we may delete the loader while this element lives o n.
405 Member<HTMLImageLoader> m_imageLoader; 411 Member<HTMLImageLoader> m_imageLoader;
406 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 412 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
407 }; 413 };
408 414
409 } // namespace blink 415 } // namespace blink
410 416
411 #endif // HTMLInputElement_h 417 #endif // HTMLInputElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698