Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2209763004: Port protocol::Parser to blink::JSONParser (Closed)

Created:
4 years, 4 months ago by iclelland
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@json-unique_ptr-backport
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port protocol::Parser to blink::JSONParser This copies the JSON parser used by the inspector into platform so that it can be used by Blink. The code is almost identical, except that it takes as input WTF::String objects and output blink::JSONValue objects. BUG=634921 Committed: https://crrev.com/e0f3188369f42c0ff445a6e698b0ab4171e9ff3c Cr-Commit-Position: refs/heads/master@{#410074}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase; type -> getType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -118 lines) Patch
A + third_party/WebKit/Source/platform/JSONParser.h View 1 chunk +10 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/platform/JSONParser.cpp View 18 chunks +64 lines, -44 lines 0 comments Download
A + third_party/WebKit/Source/platform/JSONParserTest.cpp View 1 2 20 chunks +65 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (20 generated)
pfeldman
lgtm
4 years, 4 months ago (2016-08-05 04:10:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209763004/40001
4 years, 4 months ago (2016-08-05 16:17:03 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-05 16:29:34 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:31:03 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0f3188369f42c0ff445a6e698b0ab4171e9ff3c
Cr-Commit-Position: refs/heads/master@{#410074}

Powered by Google App Engine
This is Rietveld 408576698