test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden - Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden

Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: rebased the patch. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/ast/ast.h ('K') | « test/cctest/interpreter/bytecode_expectations/PropertyCall.golden ('k') | test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden » ('j') | test/cctest/test-feedback-vector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden b/test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden

index ce4eb0ff5010f82e2aa3d61d77a80fed3e480b66..c632a76e69905073f30c2e97e703c1b9601af40a 100644

--- a/test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden

+++ b/test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden

@@ -18,20 +18,20 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 25

+bytecode array length: 26

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 45 S> */ B(LdaSmi), U8(1),

B(Star), R(0),

/* 48 E> */ B(StackCheck),

/* 64 S> */ B(Ldar), R(0),

- /* 78 E> */ B(Add), R(0),

+ /* 78 E> */ B(Add), R(0), U8(1),

B(Star), R(0),

/* 86 S> */ B(LdaSmi), U8(10),

/* 95 E> */ B(TestGreaterThan), R(0),

B(JumpIfFalse), U8(4),

/* 101 S> */ B(Jump), U8(4),

- B(Jump), U8(-15),

+ B(Jump), U8(-16),

/* 110 S> */ B(Ldar), R(0),

/* 123 S> */ B(Return),

]

@@ -51,14 +51,14 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 22

+bytecode array length: 23

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 45 S> */ B(LdaSmi), U8(1),

B(Star), R(0),

/* 48 E> */ B(StackCheck),

/* 55 S> */ B(Nop),

- /* 69 E> */ B(Add), R(0),

+ /* 69 E> */ B(Add), R(0), U8(1),

B(Star), R(0),

/* 77 S> */ B(LdaSmi), U8(10),

/* 86 E> */ B(TestGreaterThan), R(0),

@@ -80,13 +80,13 @@ snippet: "

frame size: 1

parameter count: 1

-bytecode array length: 12

+bytecode array length: 13

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 45 S> */ B(LdaSmi), U8(1),

B(Star), R(0),

/* 50 S> */ B(Nop),

- /* 64 E> */ B(Add), R(0),

+ /* 64 E> */ B(Add), R(0), U8(1),

B(Star), R(0),

/* 72 S> */ B(Nop),

/* 85 S> */ B(Return),