[Interpreter] Assign feedback slots for binary operations and use them in ignition.

test/cctest/test-feedback-vector.cc

Index: test/cctest/test-feedback-vector.cc
diff --git a/test/cctest/test-feedback-vector.cc b/test/cctest/test-feedback-vector.cc
index ba4d9a9026cc654a4d4ae7d19e85b34f8c3c4cde..bd7e55a2e12c38045666b4792c4f4dce2cf66e84 100644
--- a/test/cctest/test-feedback-vector.cc
+++ b/test/cctest/test-feedback-vector.cc
@@ -365,8 +365,8 @@ TEST(VectorLoadICSlotSharing) {
   CompileRun(
       "o = 10;"
       "function f() {"
-      "  var x = o + 10;"
-      "  return o + x + o;"
+      "  var x = o || 10;"
+      "  return o , x , o;"
       "}"
       "f();");
   Handle<JSFunction> f = GetFunction("f");
@@ -544,13 +544,16 @@ TEST(ReferenceContextAllocatesNoSlots) {
     // of x.old and x.young.
     Handle<TypeFeedbackVector> feedback_vector(f->feedback_vector());
     FeedbackVectorHelper helper(feedback_vector);
-    CHECK_EQ(6, helper.slot_count());
+    // we also assign slot for binary operations.

[Michael Starzinger, 2016/08/05 09:44:27]

nit: Capitalize comment. Or drop this one completely, it's covered by the below
comment.

[mythria, 2016/08/05 09:55:18]

Done.

+    CHECK_EQ(7, helper.slot_count());
     CHECK_SLOT_KIND(helper, 0, FeedbackVectorSlotKind::LOAD_GLOBAL_IC);
     CHECK_SLOT_KIND(helper, 1, FeedbackVectorSlotKind::STORE_IC);
     CHECK_SLOT_KIND(helper, 2, FeedbackVectorSlotKind::STORE_IC);
     CHECK_SLOT_KIND(helper, 3, FeedbackVectorSlotKind::STORE_IC);
     CHECK_SLOT_KIND(helper, 4, FeedbackVectorSlotKind::LOAD_IC);
     CHECK_SLOT_KIND(helper, 5, FeedbackVectorSlotKind::LOAD_IC);
+    // Binary operation feedback is a general slot.
+    CHECK_SLOT_KIND(helper, 6, FeedbackVectorSlotKind::GENERAL);
   }
 }