src/wasm/wasm-macro-gen.h - Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-macro-gen.h

Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/wasm-macro-gen.h

diff --git a/src/wasm/wasm-macro-gen.h b/src/wasm/wasm-macro-gen.h

index 609fe5369009095777a3c21d6145596033bf298b..abd57d505a11a51359f0b819229b7917a16efb06 100644

--- a/src/wasm/wasm-macro-gen.h

+++ b/src/wasm/wasm-macro-gen.h

@@ -343,9 +343,9 @@ class LocalDeclEncoder {

static_cast<byte>(bit_cast<uint64_t>(val) >> 56)

#define WASM_GET_LOCAL(index) kExprGetLocal, static_cast<byte>(index)

#define WASM_SET_LOCAL(index, val) val, kExprSetLocal, static_cast<byte>(index)

-#define WASM_LOAD_GLOBAL(index) kExprLoadGlobal, static_cast<byte>(index)

-#define WASM_STORE_GLOBAL(index, val) \

- val, kExprStoreGlobal, static_cast<byte>(index)

+#define WASM_GET_GLOBAL(index) kExprGetGlobal, static_cast<byte>(index)

+#define WASM_SET_GLOBAL(index, val) \

+ val, kExprSetGlobal, static_cast<byte>(index)

#define WASM_LOAD_MEM(type, index) \

index, static_cast<byte>( \

v8::internal::wasm::WasmOpcodes::LoadStoreOpcodeOf(type, false)), \

« no previous file with comments | « src/wasm/wasm-interpreter.cc ('k') | src/wasm/wasm-opcodes.h » ('j') | no next file with comments »