src/wasm/wasm-opcodes.h - Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-opcodes.h

Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/wasm/wasm-opcodes.h

diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h

index 819b897bcc975d644aa8e751e4e68e6c2d16e99f..ee84003b8a80397d71749975fb1eb2d4b357acdd 100644

--- a/src/wasm/wasm-opcodes.h

+++ b/src/wasm/wasm-opcodes.h

@@ -69,8 +69,8 @@ const WasmCodePosition kNoCodePosition = -1;

V(CallIndirect, 0x17, _) \

V(CallImport, 0x18, _) \

V(I8Const, 0xcb, _) \

- V(LoadGlobal, 0xcc, _) \

- V(StoreGlobal, 0xcd, _)

+ V(GetGlobal, 0xbb, _) \

+ V(SetGlobal, 0xbc, _)

// Load memory expressions.

#define FOREACH_LOAD_MEM_OPCODE(V) \

« no previous file with comments | « src/wasm/wasm-macro-gen.h ('k') | test/cctest/wasm/test-run-wasm.cc » ('j') | no next file with comments »