Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC.

Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. (Closed)

Created:
4 years, 4 months ago by titzer

Modified:
4 years, 4 months ago

Reviewers:
bradnelson, ahaas

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/d4392107fa961207b8a135b6c8e5626c60e1a3b6 Cr-Commit-Position: refs/heads/master@{#38262}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -84 lines)			Patch
M	src/asmjs/asm-wasm-builder.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/wasm-compiler.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/wasm-compiler.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/wasm/ast-decoder.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/wasm/wasm-interpreter.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/wasm/wasm-macro-gen.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/wasm/wasm-opcodes.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/wasm/test-run-wasm.cc	View	5 chunks	+12 lines, -14 lines	0 comments	Download
M	test/cctest/wasm/test-run-wasm-64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/wasm/test-run-wasm-module.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/wasm/test-run-wasm-relocation.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	test/mjsunit/wasm/wasm-constants.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/unittests/wasm/ast-decoder-unittest.cc	View	10 chunks	+33 lines, -33 lines	0 comments	Download
M	test/unittests/wasm/wasm-macro-gen-unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209433002/1

4 years, 4 months ago (2016-08-02 22:37:20 UTC) #8

commit-bot: I haz the power

4 years, 4 months ago (2016-08-02 22:41:04 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d4392107fa961207b8a135b6c8e5626c60e1a3b6
Cr-Commit-Position: refs/heads/master@{#38262}