Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2209363002: Remove material design resource pak infrastructure (Closed)

Created:
4 years, 4 months ago by Evan Stade
Modified:
4 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove material design resource pak infrastructure This was only still being used by OSX for three PNGs, but OSX has already switched to MD by default in the stable channel, so there's no need to keep the old assets or the heaps of code to support switching. Yay. (This CL doesn't vectorize the mac icons, it just removes the pre-md raster asset in favor of md raster assets.) BUG=505953, 613593 Committed: https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578 Cr-Commit-Position: refs/heads/master@{#410188}

Patch Set 1 #

Patch Set 2 : one more removal #

Patch Set 3 : remove another mac test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -656 lines) Patch
M chrome/BUILD.gn View 3 chunks +0 lines, -72 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/app/theme/default_100_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
D chrome/app/theme/material_100_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
D chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
D chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
D chrome/app/theme/material_200_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
D chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
D chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/chrome_browser_main_mac_browsertest.mm View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/chrome_repack_chrome_material_100_percent.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/chrome_repack_chrome_material_200_percent.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/base/resource/data_pack.h View 3 chunks +0 lines, -9 lines 0 comments Download
M ui/base/resource/data_pack.cc View 3 chunks +1 line, -10 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 4 chunks +3 lines, -29 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 5 chunks +4 lines, -41 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 4 chunks +0 lines, -41 lines 0 comments Download
D ui/base/resource/resource_bundle_mac_unittest.mm View 1 chunk +0 lines, -205 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +0 lines, -109 lines 0 comments Download
M ui/base/resource/resource_data_dll_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_data_dll_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/resource/resource_handle.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 28 (17 generated)
Evan Stade
4 years, 4 months ago (2016-08-04 15:43:01 UTC) #2
tdanderson
Nice! LGTM. I think the last remaining piece would be to rip out the MD ...
4 years, 4 months ago (2016-08-04 15:53:14 UTC) #5
oshima
can you look into mac build failure?
4 years, 4 months ago (2016-08-04 16:09:08 UTC) #8
Evan Stade
sure, should be fixed now. There may be other build failures after that one but ...
4 years, 4 months ago (2016-08-04 16:11:26 UTC) #9
oshima
lgtm
4 years, 4 months ago (2016-08-04 16:18:14 UTC) #12
Evan Stade
additional OWNERS: sadrul - ui/base/resource/ thestig - the rest of chrome/ aside from chrome/app/theme/ thanks.
4 years, 4 months ago (2016-08-04 18:18:34 UTC) #18
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-04 18:27:56 UTC) #19
sadrul
Cool. lgtm
4 years, 4 months ago (2016-08-04 18:56:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209363002/40001
4 years, 4 months ago (2016-08-05 21:14:38 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-05 22:22:57 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 22:25:01 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1b58bc469a867bc45c396ffb97a91274f692578
Cr-Commit-Position: refs/heads/master@{#410188}

Powered by Google App Engine
This is Rietveld 408576698