Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4678)

Unified Diff: chrome/BUILD.gn

Issue 2209363002: Remove material design resource pak infrastructure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove another mac test file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/theme/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 62b452d7d34f8984423ea4ec4f19fb7e915e1543..ef1468be6a91a382be88ab7ff555693b3d52af4c 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -772,16 +772,6 @@ if (is_win) {
sources += [ "$root_out_dir/chrome_200_percent.pak" ]
}
- # TODO(estade): remove material design specific resources.
- # See crbug.com/613593
- if (is_mac) {
- sources += [ "$root_out_dir/chrome_material_100_percent.pak" ]
-
- if (enable_hidpi) {
- sources += [ "$root_out_dir/chrome_material_200_percent.pak" ]
- }
- }
-
if (enable_mac_keystone) {
sources += [
"browser/mac/keystone_promote_postflight.sh",
@@ -1392,14 +1382,6 @@ group("packed_resources") {
if (enable_hidpi) {
public_deps += [ ":repack_chrome_200_percent" ]
}
-
- if (is_mac) {
- public_deps += [ ":repack_chrome_material_100_percent" ]
-
- if (enable_hidpi) {
- public_deps += [ ":repack_chrome_material_200_percent" ]
- }
- }
}
repack("packed_extra_resources") {
@@ -1636,60 +1618,6 @@ if (enable_hidpi) {
}
}
-# Generates a rule to repack a set of material design resources for the browser
-# top chrome, substituting a given string in for the percentage (e.g. "100",
-# "200").
-template("chrome_repack_material_percent") {
- percent = invoker.percent
-
- repack_name = "${target_name}_repack"
- repack_output_file =
- "$root_gen_dir/repack/chrome_material_${percent}_percent.pak"
-
- copy_name = target_name
-
- repack(repack_name) {
- visibility = [ ":$copy_name" ]
-
- # All sources should also have deps for completeness.
- sources = [
- "$root_gen_dir/chrome/theme_resources_material_${percent}_percent.pak",
- ]
-
- deps = [
- "//chrome/app/theme:theme_resources",
- "//components/resources",
- ]
-
- output = repack_output_file
- }
-
- copy(copy_name) {
- visibility = [ ":*" ]
- deps = [
- ":$repack_name",
- ]
- sources = [
- repack_output_file,
- ]
- outputs = [
- "$root_build_dir/chrome_material_${percent}_percent.pak",
- ]
- }
-}
-
-if (is_mac) {
- chrome_repack_material_percent("repack_chrome_material_100_percent") {
- percent = "100"
- }
-
- if (enable_hidpi) {
- chrome_repack_material_percent("repack_chrome_material_200_percent") {
- percent = "200"
- }
- }
-}
-
# GYP version: chrome/chrome_resources.gyp:chrome_strings
group("strings") {
public_deps = [
« no previous file with comments | « no previous file | chrome/app/theme/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698