third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp - Issue 2209203002: binding: Always throws an exception in the current realm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2209203002: binding: Always throws an exception in the current realm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

index f315c193a922377b7cba22ec70e70635cdb831b5..6c7b1e3de4e39b0513efb14349dddf12a81ff0b4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

@@ -242,8 +242,7 @@ bool ScriptCustomElementDefinition::runConstructor(Element* element)

v8::Local<v8::Value> exception = V8ThrowException::createDOMException(

m_scriptState->isolate(),

InvalidStateError,

- message,

- constructor());

+ message);

fireErrorEvent(m_scriptState.get(), message, exception, std::move(location));

return false;

}