third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp - Issue 2209203002: binding: Always throws an exception in the current realm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

Issue 2209203002: binding: Always throws an exception in the current realm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/cross-frame-accessor-throw-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

index 191f03d3b479194f68f80f5fbf6397e7c662c34c..a310637937fce08613a05664960db749dd1ec0a4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp

@@ -68,7 +68,7 @@ void ExceptionState::throwDOMException(const ExceptionCode& ec, const String& me

m_code = ec;

String processedMessage = addExceptionContext(message);

m_message = processedMessage;

- setException(V8ThrowException::createDOMException(m_isolate, ec, processedMessage, m_creationContext));

+ setException(V8ThrowException::createDOMException(m_isolate, ec, processedMessage));

}

void ExceptionState::throwSecurityError(const String& sanitizedMessage, const String& unsanitizedMessage)

@@ -80,7 +80,7 @@ void ExceptionState::throwSecurityError(const String& sanitizedMessage, const St

m_message = finalSanitized;

String finalUnsanitized = addExceptionContext(unsanitizedMessage);

- setException(V8ThrowException::createDOMException(m_isolate, SecurityError, finalSanitized, finalUnsanitized, m_creationContext));

+ setException(V8ThrowException::createDOMException(m_isolate, SecurityError, finalSanitized, finalUnsanitized));

}

void ExceptionState::setException(v8::Local<v8::Value> exception)

@@ -97,7 +97,7 @@ void ExceptionState::setException(v8::Local<v8::Value> exception)

void ExceptionState::throwException()

{

ASSERT(!m_exception.isEmpty());

- V8ThrowException::throwException(m_exception.newLocal(m_isolate), m_isolate);

+ V8ThrowException::throwException(m_isolate, m_exception.newLocal(m_isolate));

}

void ExceptionState::throwTypeError(const String& message)