Use virtual function to retrieve interface pointer

Use virtual function to retrieve interface pointer

Use virtual function to return the actual interface type instead
of the base interface type to avoid a lot of casts.

Also tidy up CFWL_Widget by encapsulating variables, and use
smart pointers for class owned member variables.

Committed: https://pdfium.googlesource.com/pdfium/+/5d8e5aa882fe8d37d32b71137f039165581ddb82

[Wei Li, 2016-08-04 07:08:46]

Description was changed from

==========
Use virtual function to retrieve interface pointer

Use virtual function to return the actual interface type instead
of the base interface type to avoid a lot of casts.
==========

to

==========
Use virtual function to retrieve interface pointer

Use virtual function to return the actual interface type instead
of the base interface type to avoid a lot of casts.

Also tidy up CFWL_Widget by encapsulating variables, and use
smart pointers for class owned member variables.
==========

[Wei Li, 2016-08-04 07:09:05]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 07:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 07:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 07:26:55]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-04 23:40:42]

Patchset #3 (id:40001) has been deleted

[Wei Li, 2016-08-04 23:41:40]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-04 23:41:41]

pls review, thanks

[Lei Zhang, 2016-08-05 17:34:19]

lgtm

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_barcode.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_barcode.cpp:45: if (!GetWidget())
auto* pWidget = GetWidget();
if (pWidget)
  pWidget->Foo();

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_barcode.cpp:51: if (!GetWidget())
auto* pWidget = GetWidget();
return pWidget ? pWidget->Foo() : 0;


.... but I see there's a whole bunch of these, so maybe just leave it alone and
not stress out about it.

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_checkbox.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_checkbox.cpp:53: return GetWidget()->GetCheckState();
Any idea why CFWL_Barcode checks the GetWidget() result but not here?

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widget.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widget.cpp:216: m_pWidgetMgr =
CFWL_WidgetMgr::GetInstance();
Put this in the initializer list and make it a const ptr?

[Wei Li, 2016-08-08 22:58:30]

Patchset #3 (id:60001) has been deleted

[Wei Li, 2016-08-08 23:55:37]

thanks

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_barcode.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_barcode.cpp:45: if (!GetWidget())
On 2016/08/05 17:34:18, Lei Zhang wrote:
> auto* pWidget = GetWidget();
> if (pWidget)
>   pWidget->Foo();

Done.

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_barcode.cpp:51: if (!GetWidget())
On 2016/08/05 17:34:18, Lei Zhang wrote:
> auto* pWidget = GetWidget();
> return pWidget ? pWidget->Foo() : 0;
> 
> 
> .... but I see there's a whole bunch of these, so maybe just leave it alone
and
> not stress out about it.

Done.

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_checkbox.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_checkbox.cpp:53: return GetWidget()->GetCheckState();
On 2016/08/05 17:34:18, Lei Zhang wrote:
> Any idea why CFWL_Barcode checks the GetWidget() result but not here?

I suspect no checking is needed as the interface is assigned during
initialization. But keep as it is for now.

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
File xfa/fwl/lightwidget/cfwl_widget.cpp (right):

https://codereview.chromium.org/2209153002/diff/20001/xfa/fwl/lightwidget/cfw...
xfa/fwl/lightwidget/cfwl_widget.cpp:216: m_pWidgetMgr =
CFWL_WidgetMgr::GetInstance();
On 2016/08/05 17:34:18, Lei Zhang wrote:
> Put this in the initializer list and make it a const ptr?

Done.

[Wei Li, 2016-08-08 23:59:17]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:59:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-09 00:03:44]

++lgtm

[commit-bot: I haz the power, 2016-08-09 00:27:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:27:10]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-09 00:30:14]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 00:30:41]

Description was changed from

==========
Use virtual function to retrieve interface pointer

Use virtual function to return the actual interface type instead
of the base interface type to avoid a lot of casts.

Also tidy up CFWL_Widget by encapsulating variables, and use
smart pointers for class owned member variables.
==========

to

==========
Use virtual function to retrieve interface pointer

Use virtual function to return the actual interface type instead
of the base interface type to avoid a lot of casts.

Also tidy up CFWL_Widget by encapsulating variables, and use
smart pointers for class owned member variables.

Committed:
https://pdfium.googlesource.com/pdfium/+/5d8e5aa882fe8d37d32b71137f039165581d...
==========

[commit-bot: I haz the power, 2016-08-09 00:30:42]

Committed patchset #3 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/5d8e5aa882fe8d37d32b71137f039165581d...