Use virtual function to retrieve interface pointer

xfa/fwl/lightwidget/cfwl_barcode.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/lightwidget/cfwl_barcode.h"
 
 #include <memory>
 
+IFWL_Barcode* CFWL_Barcode::GetWidget() {
+  return static_cast<IFWL_Barcode*>(m_pIface.get());
+}
+
+const IFWL_Barcode* CFWL_Barcode::GetWidget() const {
+  return static_cast<IFWL_Barcode*>(m_pIface.get());
+}
+
 CFWL_Barcode* CFWL_Barcode::Create() {
   return new CFWL_Barcode;
 }
 
 FWL_Error CFWL_Barcode::Initialize(const CFWL_WidgetProperties* pProperties) {
   if (m_pIface)
     return FWL_Error::Indefinite;
   if (pProperties) {
     *m_pProperties = *pProperties;
   }
   std::unique_ptr<IFWL_Barcode> pBarcode(IFWL_Barcode::Create(
       m_pProperties->MakeWidgetImpProperties(&m_barcodeData)));
   FWL_Error ret = pBarcode->Initialize();
   if (ret != FWL_Error::Succeeded) {
     return ret;
   }
-  m_pIface = pBarcode.release();
+  m_pIface = std::move(pBarcode);
   CFWL_Widget::Initialize();
   return FWL_Error::Succeeded;
 }
 
 CFWL_Barcode::CFWL_Barcode() {}
 
 CFWL_Barcode::~CFWL_Barcode() {}
 
 void CFWL_Barcode::SetType(BC_TYPE type) {
-  if (!m_pIface)
+  if (!GetWidget())

[Lei Zhang, 2016/08/05 17:34:18]

auto* pWidget = GetWidget();
if (pWidget)
  pWidget->Foo();

[Wei Li, 2016/08/08 23:55:37]

Done.

     return;
-  static_cast<IFWL_Barcode*>(m_pIface)->SetType(type);
+  GetWidget()->SetType(type);
 }
 
 FX_BOOL CFWL_Barcode::IsProtectedType() {
-  if (!m_pIface)
+  if (!GetWidget())

[Lei Zhang, 2016/08/05 17:34:18]

auto* pWidget = GetWidget();
return pWidget ? pWidget->Foo() : 0;


.... but I see there's a whole bunch of these, so maybe just leave it alone and
not stress out about it.

[Wei Li, 2016/08/08 23:55:37]

Done.

     return 0;
-  return static_cast<IFWL_Barcode*>(m_pIface)->IsProtectedType();
+  return GetWidget()->IsProtectedType();
 }
 
 CFWL_Barcode::CFWL_BarcodeDP::CFWL_BarcodeDP()
     : m_dwAttributeMask(FWL_BCDATTRIBUTE_NONE) {}
 
 FWL_Error CFWL_Barcode::CFWL_BarcodeDP::GetCaption(IFWL_Widget* pWidget,
                                                    CFX_WideString& wsCaption) {
   return FWL_Error::Succeeded;
 }
 
@@ skipping 45 matching lines @@
   return m_nECLevel;
 }
 
 FX_BOOL CFWL_Barcode::CFWL_BarcodeDP::GetTruncated() {
   return m_bTruncated;
 }
 
 uint32_t CFWL_Barcode::CFWL_BarcodeDP::GetBarcodeAttributeMask() {
   return m_dwAttributeMask;
 }