Change wildcard source expression matching to conform latest spec

chrome/browser/pdf/pdf_extension_test.cc

Index: chrome/browser/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/pdf/pdf_extension_test.cc b/chrome/browser/pdf/pdf_extension_test.cc
index dca4eb548b3dc23d9bee072b00e834213c2fa205..d5a35dd96d0fa5700cdf53775774c8138eb8c2b8 100644
--- a/chrome/browser/pdf/pdf_extension_test.cc
+++ b/chrome/browser/pdf/pdf_extension_test.cc
@@ -464,6 +464,20 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionTest, EnsureSameOriginRepliesAllowed) {
                            true);
 }
 
+// This test ensures that PDF can be loaded from local file
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, EnsurePDFFromLocalFileLoads) {
+  base::FilePath test_dir;
+  ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &test_dir));

[Lei Zhang, 2016/08/08 23:16:24]

You can do PathService::Get(chrome::DIR_TEST_DATA, ...) and skip the next 3
lines.

[Sergey Shekyan, 2016/08/08 23:55:42]

I assumed so too, but unfortunately, path set by
PathService::Get(chrome::DIR_TEST_DATA, ...) is like
`file:///path_to_my_chromium_source_code/src/base/test/data/pdf/test.pdf`, where
`base` doesn't exist.

What would you suggest?

[Lei Zhang, 2016/08/08 23:57:16]

Really? Because we use just that in several places above. Did you putin
base::DIR_TEST_DATA instead of chrome::DIR_TEST_DATA?

+  test_dir = test_dir.AppendASCII("chrome");
+  test_dir = test_dir.AppendASCII("test");
+  test_dir = test_dir.AppendASCII("data");
+  test_dir = test_dir.AppendASCII("pdf");
+  test_dir = test_dir.AppendASCII("test.pdf");

[Lei Zhang, 2016/08/08 23:16:24]

Please sanity check and make sure the final FilePath exists.

[Sergey Shekyan, 2016/08/08 23:55:42]

Acknowledged.

+  GURL test_pdf_url("file://" + test_dir.MaybeAsASCII());
+  content::WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
+  ASSERT_TRUE(guest_contents);
+}
+
 // This test ensures that link permissions are enforced properly in PDFs.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkPermissions) {
   GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test.pdf"));