Change wildcard source expression matching to conform latest spec

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
@@ skipping 446 matching lines @@
       "</body></html>";
   TestGetSelectedTextReply(GURL(data_url), false);
 }
 
 // Ensure same-origin replies do work for getSelectedText.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, EnsureSameOriginRepliesAllowed) {
   TestGetSelectedTextReply(embedded_test_server()->GetURL("/pdf/test.pdf"),
                            true);
 }
 
+// This test ensures that PDF can be loaded from local file
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, EnsurePDFFromLocalFileLoads) {
+  base::FilePath test_dir;
+  ASSERT_TRUE(PathService::Get(base::DIR_SOURCE_ROOT, &test_dir));

[Lei Zhang, 2016/08/08 23:16:24]

You can do PathService::Get(chrome::DIR_TEST_DATA, ...) and skip the next 3
lines.

[Sergey Shekyan, 2016/08/08 23:55:42]

I assumed so too, but unfortunately, path set by
PathService::Get(chrome::DIR_TEST_DATA, ...) is like
`file:///path_to_my_chromium_source_code/src/base/test/data/pdf/test.pdf`, where
`base` doesn't exist.

What would you suggest?

[Lei Zhang, 2016/08/08 23:57:16]

Really? Because we use just that in several places above. Did you putin
base::DIR_TEST_DATA instead of chrome::DIR_TEST_DATA?

+  test_dir = test_dir.AppendASCII("chrome");
+  test_dir = test_dir.AppendASCII("test");
+  test_dir = test_dir.AppendASCII("data");
+  test_dir = test_dir.AppendASCII("pdf");
+  test_dir = test_dir.AppendASCII("test.pdf");

[Lei Zhang, 2016/08/08 23:16:24]

Please sanity check and make sure the final FilePath exists.

[Sergey Shekyan, 2016/08/08 23:55:42]

Acknowledged.

+  GURL test_pdf_url("file://" + test_dir.MaybeAsASCII());
+  content::WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
+  ASSERT_TRUE(guest_contents);
+}
+
 // This test ensures that link permissions are enforced properly in PDFs.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkPermissions) {
   GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test.pdf"));
   content::WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
   ASSERT_TRUE(guest_contents);
 
   // chrome://favicon links should be allowed for PDFs, while chrome://settings
   // links should not.
   GURL valid_link_url("chrome://favicon/https://www.google.ca/");
   GURL invalid_link_url("chrome://settings");
@@ skipping 362 matching lines @@
   int tab_count = browser()->tab_strip_model()->count();
   ASSERT_EQ(2, tab_count);
 
   content::WebContents* active_web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_NE(web_contents, active_web_contents);
 
   const GURL& url = active_web_contents->GetURL();
   ASSERT_EQ(std::string("http://www.example.com/"), url.spec());
 }