chrome/browser/ui/views/bookmarks/bookmark_bar_view.h - Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set a border on the BookmarkInstructionsView instance and update GetPreferredSize() to respect it. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

index a48121452027e998f259762e2c1fa6af67f41cb4..36cff69de55dcc3597355fe040055ca729bcc9a2 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

@@ -385,6 +385,10 @@ class BookmarkBarView : public views::AccessiblePaneView,

SchedulePaint();

}

+ // Calculate and return the height of the bookmark bar with added padding to

+ // the preferred height if the font is taller than normal. (eg. Hindi text).

Evan Stade 2016/08/08 16:10:57 I can't parse this sentence, and I'm not sure it's

kylix_rd 2016/08/08 17:05:23 Should there be no comment? I suppose the name is

+ int GetPreferredHeight() const;

// Needed to react to kShowAppsShortcutInBookmarkBar changes.

PrefChangeRegistrar profile_pref_registrar_;