Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 2208973003: Add some extra height to bookmark bar if the font wants to be larger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set a border on the BookmarkInstructionsView instance and update GetPreferredSize() to respect it. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 // Updates the visibility of the apps shortcut based on the pref value. 378 // Updates the visibility of the apps shortcut based on the pref value.
379 void OnAppsPageShortcutVisibilityPrefChanged(); 379 void OnAppsPageShortcutVisibilityPrefChanged();
380 380
381 void OnShowManagedBookmarksPrefChanged(); 381 void OnShowManagedBookmarksPrefChanged();
382 382
383 void LayoutAndPaint() { 383 void LayoutAndPaint() {
384 Layout(); 384 Layout();
385 SchedulePaint(); 385 SchedulePaint();
386 } 386 }
387 387
388 // Calculate and return the height of the bookmark bar with added padding to
389 // the preferred height if the font is taller than normal. (eg. Hindi text).
Evan Stade 2016/08/08 16:10:57 I can't parse this sentence, and I'm not sure it's
kylix_rd 2016/08/08 17:05:23 Should there be no comment? I suppose the name is
390 int GetPreferredHeight() const;
391
388 // Needed to react to kShowAppsShortcutInBookmarkBar changes. 392 // Needed to react to kShowAppsShortcutInBookmarkBar changes.
389 PrefChangeRegistrar profile_pref_registrar_; 393 PrefChangeRegistrar profile_pref_registrar_;
390 394
391 // Used for opening urls. 395 // Used for opening urls.
392 content::PageNavigator* page_navigator_; 396 content::PageNavigator* page_navigator_;
393 397
394 // BookmarkModel that owns the entries and folders that are shown in this 398 // BookmarkModel that owns the entries and folders that are shown in this
395 // view. This is owned by the Profile. 399 // view. This is owned by the Profile.
396 bookmarks::BookmarkModel* model_; 400 bookmarks::BookmarkModel* model_;
397 401
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
456 460
457 base::ObserverList<BookmarkBarViewObserver> observers_; 461 base::ObserverList<BookmarkBarViewObserver> observers_;
458 462
459 // Factory used to delay showing of the drop menu. 463 // Factory used to delay showing of the drop menu.
460 base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_; 464 base::WeakPtrFactory<BookmarkBarView> show_folder_method_factory_;
461 465
462 DISALLOW_COPY_AND_ASSIGN(BookmarkBarView); 466 DISALLOW_COPY_AND_ASSIGN(BookmarkBarView);
463 }; 467 };
464 468
465 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_ 469 #endif // CHROME_BROWSER_UI_VIEWS_BOOKMARKS_BOOKMARK_BAR_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698